Performs modular reduction for all scalars. #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-wood
reviewed
Feb 1, 2022
chris-wood
approved these changes
Feb 1, 2022
|
The change looks good! I wonder if we can expand on the tests, though. |
armfazh
force-pushed
the
p384/reduceScalar
branch
from
238bf3e
to
6507857
Compare
bwesterb
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scalars are reduced only when its size in bytes is bigger that the order=N.
There are, however, scalars of such size but larger than N that escaped to be reduced.
With this change, now scalars are fully reduced.
Fixes #312