Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

group: adds Set/Copy methods for group elements and scalars #326

Merged
merged 2 commits into from
Mar 7, 2022
Merged

group: adds Set/Copy methods for group elements and scalars #326

merged 2 commits into from
Mar 7, 2022

Conversation

armfazh
Copy link
Contributor

@armfazh armfazh commented Mar 4, 2022

No description provided.

@armfazh armfazh requested a review from chris-wood March 4, 2022 21:47
@armfazh armfazh self-assigned this Mar 4, 2022
@armfazh armfazh requested a review from bwesterb March 4, 2022 23:38
chris-wood
chris-wood approved these changes Mar 5, 2022
View reviewed changes
Copy link
Contributor

@chris-wood chris-wood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending resolution to @lukevalenta's question.

@armfazh armfazh merged commit fede922 into cloudflare:master Mar 7, 2022
@armfazh armfazh deleted the groupSetFunc branch March 7, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwesterb bwesterb bwesterb approved these changes

@chris-wood chris-wood chris-wood approved these changes

@lukevalenta lukevalenta lukevalenta approved these changes

Assignees

@armfazh armfazh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@armfazh @bwesterb @chris-wood @lukevalenta