Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrangler delete endpoints #166

Merged
merged 3 commits into from
Oct 15, 2021

Conversation

ocsfrank
Copy link
Contributor

Adds two endpoints for listing a script bindings and for deleting a Durable Object. These two endpoints are used in a Wrangler PR - cloudflare/wrangler-legacy#2086.

update delete_script

add list_scripts

add bindings and do

update namings

remove endpoints
@jspspike
Copy link
Contributor

This looks good, where is the documentation for the durable objects endpoint? I couldn't find anything on api.cloudflare.com

@ocsfrank
Copy link
Contributor Author

ocsfrank commented Oct 14, 2021

There weren't any last time I checked. I think api.cloudflare.com might be a bit outdated as it doesn't include other endpoints either. Someone else in the Workers team should know more about these endpoints.

@nilslice
Copy link
Contributor

If someone w/ merge capabilities would add a review and merge if OK, that would be great. Thank you!

@nmldiegues
Copy link
Contributor

nmldiegues commented Oct 15, 2021

Structurally looks good.

In terms of endpoint correctness, I'll trust you've checked :)

@nmldiegues nmldiegues merged commit ff11f3b into cloudflare:master Oct 15, 2021
@taylorlee taylorlee mentioned this pull request Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants