Fix issue with empty JSON object responses from network policy endpoints #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Hey GFriedrich! The commit authors and yourself have already signed the CLA. |
|
Thanks for the fix @GFriedrich - this resolves an issue that I'd run into only hours earlier when testing #984, so couldn't have been better timed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[resolves #969]
The issue here was a bit different than initially thought: The code works just fine for Jackson libraries up to version 2.9.7
From version 2.9.8 on the handling of "Void" type deserialization has been changed. This is due to FasterXML/jackson-databind#2197
By that the Jackson deserializer will return "null" instead of illegally instantiating the "Void" class via reflection. This in turn breaks the Reactor mapping as it doesn't allow null.
This PR will keep the backward compatibility with Jackson 2.9.7 and below, but will also make the code compatible to Jackson 2.9.8 and above.