Add support to send LOG and EVENT to OtelCollector as logs #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_AS_OTEL_LOGS`) to send loggregator events to OTL logs service
- we tested the shorter timeout for the eventually, fails at 0.1, passes at 0.2, so going with 0.5 as the timeout. - not adding temporary_ before the bosh properties. Seems like this pattern is going to live for a while. - decided to use one property for logs and events, since logs and events both get translated to otlp logs. Signed-off-by: Andrew Costa <andrew.costa@broadcom.com> Signed-off-by: Matthew Kocher <matthew.kocher@broadcom.com> Signed-off-by: Ivan Protsiuk <ivan.protsiuk@broadcom.com>
- Renaming this without a major version as it was prefixed with temporary. We don't think anyone is using this, apologies if you are and this breaks your environment. Signed-off-by: Ivan Protsiuk <ivan.protsiuk@broadcom.com>
ctlong
previously approved these changes
Aug 14, 2024
- new linter release, new problems Signed-off-by: Matthew Kocher <matthew.kocher@broadcom.com>
ctlong
approved these changes
Aug 15, 2024
chombium
approved these changes
Aug 15, 2024
10 tasks
|
In cloudfoundry/otel-collector-release#48 we made the otel-collector release add noop pipelines for any signal that doesn't have a pipeline defined. This should make it safe to turn these properties on by default, and allow users to turn them off as a (probably minor) performance optimization if they want to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This incorporates the changes from #595 to add support for forwarding logs over otlp. It also adds configuration to turn logs/metrics/traces on and off.
We don't believe anyone is using it, and since we were adding the other signals we figure these properties are as permanent as any others.
Type of change
Testing performed?
Checklist:
mainbranch, or relevant version branchIf you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack