chore: add support for hostNetwork in chart
#324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marckhair
requested review from
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco and
sxd
as code owners
marckhair
changed the title
hostNetwork in chart
marckhair
force-pushed
the
chore/add-hostnetwork-support
branch
from
3858d5b
to
cea313c
Compare
|
So it seems like #185 also partially addresses the same issue with running cloudnative-pg on EKS with a custom CNI. However, that other PR misses the That other PR has been opened for months without any attention being given to it from the maintainers. For such a simple change that would help a lot of folks, I'd expect maintainers to accept and merge this PR without excessive delays. I totally understand the open source aspect of such a project, but again, those two PRs can easily be reviewed in a few minutes and would bring a lot of value to some people. Thank you for building cloudnative-pg, it is an incredibly useful operator! |
|
@gbartolini @leonardoce @mnencia @phisco @sxd |
|
@mboutet The problem is a lack of test suite, for both helm charts. We've made mistakes in the past, merging bugs. And the time requirements for merging with manual testing are increased. I tried KUTTL a while ago, but mostly had issues with it. @phisco suggested I try Chainsaw instead, but before we have something like that merging will be slow. I know it's 15 lines of code, but we've done damage with less. |
itay-grudev
added
the
chart( operator )
itay-grudev
reviewed
Jul 2, 2024
charts/cloudnative-pg/values.yaml
Outdated
| @@ -29,6 +29,9 @@ imagePullSecrets: [] | |||
| nameOverride: "" | |||
| fullnameOverride: "" | |||
|
|
|||
| hostNetwork: false | |||
| dnsPolicy: "ClusterFirst" | |||
There was a problem hiding this comment.
How is ClusterFirst better than Default with hostNetowork: false?
There was a problem hiding this comment.
Shouldn't it be kept to Default for backwards compatibility?
There was a problem hiding this comment.
I think we could simply keep it as an empty string which will result in the field not being rendered in the Deployment.
However, from https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-dns-policy, it seems like ClusterFirst is the actual default if the field is not specified in the PodSpec.
There was a problem hiding this comment.
Changed the default value of dnsPolicy to an empty string: 4bd27cd
mboutet
reviewed
Jul 2, 2024
charts/cloudnative-pg/values.yaml
Outdated
| @@ -29,6 +29,9 @@ imagePullSecrets: [] | |||
| nameOverride: "" | |||
| fullnameOverride: "" | |||
|
|
|||
| hostNetwork: false | |||
| dnsPolicy: "ClusterFirst" | |||
There was a problem hiding this comment.
Suggested change
| dnsPolicy: "ClusterFirst" | |
| dnsPolicy: "" |
There was a problem hiding this comment.
As @itay-grudev properly mention this should be "Default" since that's the proper default an empty string is not on the list of possible options
There was a problem hiding this comment.
On the other hands, these two values should be set only if there's any value set, having a default it's like mandatory, in platforms like OpenShift this hostNetwork value and dnsPolicy may not need to be set
There was a problem hiding this comment.
@sxd, the default is actually ClusterFirst as per https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-dns-policy.
"Default" is not the default DNS policy. If dnsPolicy is not explicitly specified, then "ClusterFirst" is used.
There was a problem hiding this comment.
As I said, better to not set any default value, only set if it's set by the user
There was a problem hiding this comment.
Changed the default value of dnsPolicy to an empty string: 4bd27cd
There was a problem hiding this comment.
On the other hands, these two values should be set only if there's any value set, having a default it's like mandatory, in platforms like OpenShift this hostNetwork value and dnsPolicy may not need to be set
That's why I suggested we use "" for dnsPolicy in the values.yaml file. That way, the field won't get rendered in the deployment template.
hostNetwork is already false by default in the values.yaml, so it won't get rendered as it is wrapped in a conditional.
Edit: Wrote this before seeing #324 (comment).
Signed-off-by: Marc Khair <67377306+marckhair@users.noreply.github.com>
Signed-off-by: Marc Khair <67377306+marckhair@users.noreply.github.com>
marckhair
force-pushed
the
chore/add-hostnetwork-support
branch
from
8256848
to
4bd27cd
Compare
|
Tested default value | non default value combinations using |
The problem is not if they will render, but whether they will be accepted by K8s. I think a |
I passed the output of helm template to kubeconform in strict mode. Dry run is too complicated, it requires a cluster. |
sxd
approved these changes
Jul 30, 2024
szinn
pushed a commit
to szinn/k8s-homelab
that referenced
this pull request
Jul 30, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cloudnative-pg](https://cloudnative-pg.io) ([source](https://github.com/cloudnative-pg/charts)) | patch | `0.21.5` -> `0.21.6` | --- ### Release Notes <details> <summary>cloudnative-pg/charts (cloudnative-pg)</summary> ### [`v0.21.6`](https://github.com/cloudnative-pg/charts/releases/tag/cloudnative-pg-v0.21.6) [Compare Source](https://github.com/cloudnative-pg/charts/compare/cloudnative-pg-v0.21.5...cloudnative-pg-v0.21.6) CloudNativePG Operator Helm Chart #### What's Changed - Add walStorage capability and remove gkeEnvironment conflict in cluster chart. by [@​rocket357](https://github.com/rocket357) in [cloudnative-pg/charts#312 - chore(deps): update actions/setup-python action to v5.1.1 by [@​renovate](https://github.com/renovate) in [cloudnative-pg/charts#330 - chore(deps): update docker/login-action action to v3.3.0 by [@​renovate](https://github.com/renovate) in [cloudnative-pg/charts#333 - chore: add support for `hostNetwork` in chart by [@​marckhair](https://github.com/marckhair) in [cloudnative-pg/charts#324 - feat(cloudnative-pg): Configuration of PodMonitor relabeling rules by [@​npdgm](https://github.com/npdgm) in [cloudnative-pg/charts#148 - fix: linter - trailing white spaces by [@​sxd](https://github.com/sxd) in [cloudnative-pg/charts#339 - Release cloudnative-pg-v0.21.6 by [@​github-actions](https://github.com/github-actions) in [cloudnative-pg/charts#340 #### New Contributors - [@​rocket357](https://github.com/rocket357) made their first contribution in [cloudnative-pg/charts#312 - [@​marckhair](https://github.com/marckhair) made their first contribution in [cloudnative-pg/charts#324 - [@​npdgm](https://github.com/npdgm) made their first contribution in [cloudnative-pg/charts#148 **Full Changelog**: cloudnative-pg/charts@cloudnative-pg-v0.21.5...cloudnative-pg-v0.21.6 </details> <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMS4wIiwidXBkYXRlZEluVmVyIjoiMzguMTEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvaGVsbSIsInR5cGUvcGF0Y2giXX0=--> Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>
szinn
pushed a commit
to szinn/k8s-homelab
that referenced
this pull request
Jul 30, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cloudnative-pg](https://cloudnative-pg.io) ([source](https://github.com/cloudnative-pg/charts)) | patch | `0.21.5` -> `0.21.6` | --- ### Release Notes <details> <summary>cloudnative-pg/charts (cloudnative-pg)</summary> ### [`v0.21.6`](https://github.com/cloudnative-pg/charts/releases/tag/cloudnative-pg-v0.21.6) [Compare Source](https://github.com/cloudnative-pg/charts/compare/cloudnative-pg-v0.21.5...cloudnative-pg-v0.21.6) CloudNativePG Operator Helm Chart #### What's Changed - Add walStorage capability and remove gkeEnvironment conflict in cluster chart. by [@​rocket357](https://github.com/rocket357) in [cloudnative-pg/charts#312 - chore(deps): update actions/setup-python action to v5.1.1 by [@​renovate](https://github.com/renovate) in [cloudnative-pg/charts#330 - chore(deps): update docker/login-action action to v3.3.0 by [@​renovate](https://github.com/renovate) in [cloudnative-pg/charts#333 - chore: add support for `hostNetwork` in chart by [@​marckhair](https://github.com/marckhair) in [cloudnative-pg/charts#324 - feat(cloudnative-pg): Configuration of PodMonitor relabeling rules by [@​npdgm](https://github.com/npdgm) in [cloudnative-pg/charts#148 - fix: linter - trailing white spaces by [@​sxd](https://github.com/sxd) in [cloudnative-pg/charts#339 - Release cloudnative-pg-v0.21.6 by [@​github-actions](https://github.com/github-actions) in [cloudnative-pg/charts#340 #### New Contributors - [@​rocket357](https://github.com/rocket357) made their first contribution in [cloudnative-pg/charts#312 - [@​marckhair](https://github.com/marckhair) made their first contribution in [cloudnative-pg/charts#324 - [@​npdgm](https://github.com/npdgm) made their first contribution in [cloudnative-pg/charts#148 **Full Changelog**: cloudnative-pg/charts@cloudnative-pg-v0.21.5...cloudnative-pg-v0.21.6 </details> <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMS4wIiwidXBkYXRlZEluVmVyIjoiMzguMTEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvaGVsbSIsInR5cGUvcGF0Y2giXX0=--> Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>
nrdufour
pushed a commit
to nrdufour/home-ops
that referenced
this pull request
Jul 30, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cloudnative-pg](https://cloudnative-pg.io) ([source](https://github.com/cloudnative-pg/charts)) | patch | `0.21.5` -> `0.21.6` | --- ### Release Notes <details> <summary>cloudnative-pg/charts (cloudnative-pg)</summary> ### [`v0.21.6`](https://github.com/cloudnative-pg/charts/releases/tag/cloudnative-pg-v0.21.6) [Compare Source](cloudnative-pg/charts@cloudnative-pg-v0.21.5...cloudnative-pg-v0.21.6) CloudNativePG Operator Helm Chart #### What's Changed - Add walStorage capability and remove gkeEnvironment conflict in cluster chart. by [@​rocket357](https://github.com/rocket357) in cloudnative-pg/charts#312 - chore(deps): update actions/setup-python action to v5.1.1 by [@​renovate](https://github.com/renovate) in cloudnative-pg/charts#330 - chore(deps): update docker/login-action action to v3.3.0 by [@​renovate](https://github.com/renovate) in cloudnative-pg/charts#333 - chore: add support for `hostNetwork` in chart by [@​marckhair](https://github.com/marckhair) in cloudnative-pg/charts#324 - feat(cloudnative-pg): Configuration of PodMonitor relabeling rules by [@​npdgm](https://github.com/npdgm) in cloudnative-pg/charts#148 - fix: linter - trailing white spaces by [@​sxd](https://github.com/sxd) in cloudnative-pg/charts#339 - Release cloudnative-pg-v0.21.6 by [@​github-actions](https://github.com/github-actions) in cloudnative-pg/charts#340 #### New Contributors - [@​rocket357](https://github.com/rocket357) made their first contribution in cloudnative-pg/charts#312 - [@​marckhair](https://github.com/marckhair) made their first contribution in cloudnative-pg/charts#324 - [@​npdgm](https://github.com/npdgm) made their first contribution in cloudnative-pg/charts#148 **Full Changelog**: cloudnative-pg/charts@cloudnative-pg-v0.21.5...cloudnative-pg-v0.21.6 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMS4wIiwidXBkYXRlZEluVmVyIjoiMzguMTEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Reviewed-on: https://git.internal/nrdufour/home-ops/pulls/482 Co-authored-by: Renovate <renovate@ptinem.casa> Co-committed-by: Renovate <renovate@ptinem.casa>
lumiere-bot bot
added a commit
to coolguy1771/home-ops
that referenced
this pull request
Jul 30, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cloudnative-pg](https://cloudnative-pg.io) ([source](https://github.com/cloudnative-pg/charts)) | patch | `0.21.5` -> `0.21.6` | --- ### Release Notes <details> <summary>cloudnative-pg/charts (cloudnative-pg)</summary> ### [`v0.21.6`](https://github.com/cloudnative-pg/charts/releases/tag/cloudnative-pg-v0.21.6) [Compare Source](https://github.com/cloudnative-pg/charts/compare/cloudnative-pg-v0.21.5...cloudnative-pg-v0.21.6) CloudNativePG Operator Helm Chart #### What's Changed - Add walStorage capability and remove gkeEnvironment conflict in cluster chart. by [@​rocket357](https://github.com/rocket357) in [cloudnative-pg/charts#312 - chore(deps): update actions/setup-python action to v5.1.1 by [@​renovate](https://github.com/renovate) in [cloudnative-pg/charts#330 - chore(deps): update docker/login-action action to v3.3.0 by [@​renovate](https://github.com/renovate) in [cloudnative-pg/charts#333 - chore: add support for `hostNetwork` in chart by [@​marckhair](https://github.com/marckhair) in [cloudnative-pg/charts#324 - feat(cloudnative-pg): Configuration of PodMonitor relabeling rules by [@​npdgm](https://github.com/npdgm) in [cloudnative-pg/charts#148 - fix: linter - trailing white spaces by [@​sxd](https://github.com/sxd) in [cloudnative-pg/charts#339 - Release cloudnative-pg-v0.21.6 by [@​github-actions](https://github.com/github-actions) in [cloudnative-pg/charts#340 #### New Contributors - [@​rocket357](https://github.com/rocket357) made their first contribution in [cloudnative-pg/charts#312 - [@​marckhair](https://github.com/marckhair) made their first contribution in [cloudnative-pg/charts#324 - [@​npdgm](https://github.com/npdgm) made their first contribution in [cloudnative-pg/charts#148 **Full Changelog**: cloudnative-pg/charts@cloudnative-pg-v0.21.5...cloudnative-pg-v0.21.6 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMS4wIiwidXBkYXRlZEluVmVyIjoiMzguMTEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvaGVsbSIsInR5cGUvcGF0Y2giXX0=--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
bojanrajkovic
pushed a commit
to bojanrajkovic/home.coderinserepeat.com
that referenced
this pull request
Aug 1, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [cloudnative-pg](https://cloudnative-pg.io) ([source](https://github.com/cloudnative-pg/charts)) | helm_release | patch | `0.21.5` -> `0.21.6` | --- ### Release Notes <details> <summary>cloudnative-pg/charts (cloudnative-pg)</summary> ### [`v0.21.6`](https://github.com/cloudnative-pg/charts/releases/tag/cloudnative-pg-v0.21.6) [Compare Source](https://github.com/cloudnative-pg/charts/compare/cloudnative-pg-v0.21.5...cloudnative-pg-v0.21.6) CloudNativePG Operator Helm Chart #### What's Changed - Add walStorage capability and remove gkeEnvironment conflict in cluster chart. by [@​rocket357](https://github.com/rocket357) in [cloudnative-pg/charts#312 - chore(deps): update actions/setup-python action to v5.1.1 by [@​renovate](https://github.com/renovate) in [cloudnative-pg/charts#330 - chore(deps): update docker/login-action action to v3.3.0 by [@​renovate](https://github.com/renovate) in [cloudnative-pg/charts#333 - chore: add support for `hostNetwork` in chart by [@​marckhair](https://github.com/marckhair) in [cloudnative-pg/charts#324 - feat(cloudnative-pg): Configuration of PodMonitor relabeling rules by [@​npdgm](https://github.com/npdgm) in [cloudnative-pg/charts#148 - fix: linter - trailing white spaces by [@​sxd](https://github.com/sxd) in [cloudnative-pg/charts#339 - Release cloudnative-pg-v0.21.6 by [@​github-actions](https://github.com/github-actions) in [cloudnative-pg/charts#340 #### New Contributors - [@​rocket357](https://github.com/rocket357) made their first contribution in [cloudnative-pg/charts#312 - [@​marckhair](https://github.com/marckhair) made their first contribution in [cloudnative-pg/charts#324 - [@​npdgm](https://github.com/npdgm) made their first contribution in [cloudnative-pg/charts#148 **Full Changelog**: cloudnative-pg/charts@cloudnative-pg-v0.21.5...cloudnative-pg-v0.21.6 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/bojanrajkovic/home.coderinserepeat.com). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
sp3nx0r
pushed a commit
to sp3nx0r/homelab
that referenced
this pull request
Aug 3, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cloudnative-pg](https://cloudnative-pg.io) ([source](https://github.com/cloudnative-pg/charts)) | patch | `0.21.5` -> `0.21.6` | --- ### Release Notes <details> <summary>cloudnative-pg/charts (cloudnative-pg)</summary> ### [`v0.21.6`](https://github.com/cloudnative-pg/charts/releases/tag/cloudnative-pg-v0.21.6) [Compare Source](https://github.com/cloudnative-pg/charts/compare/cloudnative-pg-v0.21.5...cloudnative-pg-v0.21.6) CloudNativePG Operator Helm Chart #### What's Changed - Add walStorage capability and remove gkeEnvironment conflict in cluster chart. by [@​rocket357](https://github.com/rocket357) in [cloudnative-pg/charts#312 - chore(deps): update actions/setup-python action to v5.1.1 by [@​renovate](https://github.com/renovate) in [cloudnative-pg/charts#330 - chore(deps): update docker/login-action action to v3.3.0 by [@​renovate](https://github.com/renovate) in [cloudnative-pg/charts#333 - chore: add support for `hostNetwork` in chart by [@​marckhair](https://github.com/marckhair) in [cloudnative-pg/charts#324 - feat(cloudnative-pg): Configuration of PodMonitor relabeling rules by [@​npdgm](https://github.com/npdgm) in [cloudnative-pg/charts#148 - fix: linter - trailing white spaces by [@​sxd](https://github.com/sxd) in [cloudnative-pg/charts#339 - Release cloudnative-pg-v0.21.6 by [@​github-actions](https://github.com/github-actions) in [cloudnative-pg/charts#340 #### New Contributors - [@​rocket357](https://github.com/rocket357) made their first contribution in [cloudnative-pg/charts#312 - [@​marckhair](https://github.com/marckhair) made their first contribution in [cloudnative-pg/charts#324 - [@​npdgm](https://github.com/npdgm) made their first contribution in [cloudnative-pg/charts#148 **Full Changelog**: cloudnative-pg/charts@cloudnative-pg-v0.21.5...cloudnative-pg-v0.21.6 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/sp3nx0r/homelab). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9wYXRjaCJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
rouke-broersma
pushed a commit
to broersma-forslund/homelab
that referenced
this pull request
Aug 5, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cloudnative-pg](https://cloudnative-pg.io) ([source](https://github.com/cloudnative-pg/charts)) | patch | `0.21.5` -> `0.21.6` | --- ### Release Notes <details> <summary>cloudnative-pg/charts (cloudnative-pg)</summary> ### [`v0.21.6`](https://github.com/cloudnative-pg/charts/releases/tag/cloudnative-pg-v0.21.6) CloudNativePG Operator Helm Chart ##### What's Changed - Add walStorage capability and remove gkeEnvironment conflict in cluster chart. by [@​rocket357](https://github.com/rocket357) in [cloudnative-pg/charts#312 - chore(deps): update actions/setup-python action to v5.1.1 by [@​renovate](https://github.com/renovate) in [cloudnative-pg/charts#330 - chore(deps): update docker/login-action action to v3.3.0 by [@​renovate](https://github.com/renovate) in [cloudnative-pg/charts#333 - chore: add support for `hostNetwork` in chart by [@​marckhair](https://github.com/marckhair) in [cloudnative-pg/charts#324 - feat(cloudnative-pg): Configuration of PodMonitor relabeling rules by [@​npdgm](https://github.com/npdgm) in [cloudnative-pg/charts#148 - fix: linter - trailing white spaces by [@​sxd](https://github.com/sxd) in [cloudnative-pg/charts#339 - Release cloudnative-pg-v0.21.6 by [@​github-actions](https://github.com/github-actions) in [cloudnative-pg/charts#340 ##### New Contributors - [@​rocket357](https://github.com/rocket357) made their first contribution in [cloudnative-pg/charts#312 - [@​marckhair](https://github.com/marckhair) made their first contribution in [cloudnative-pg/charts#324 - [@​npdgm](https://github.com/npdgm) made their first contribution in [cloudnative-pg/charts#148 **Full Changelog**: cloudnative-pg/charts@cloudnative-pg-v0.21.5...cloudnative-pg-v0.21.6 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/broersma-forslund/homelab). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
PrivatePuffin
pushed a commit
to truecharts/charts
that referenced
this pull request
Sep 9, 2024
](https://renovatebot.com){kind=link}
This PR contains the following updates: | Package | Update | Change | |---|---|---| | | lockFileMaintenance | All locks refreshed | | [localpv-provisioner](http://www.openebs.io/) ([source](https://github.com/openebs/dynamic-localpv-provisioner)) | minor | `4.0.0` -> `4.1.0` | | [gpu-operator](https://docs.nvidia.com/datacenter/cloud-native/gpu-operator/overview.html) ([source](https://github.com/NVIDIA/gpu-operator)) | minor | `v24.3.0` -> `v24.6.1` | | [nvidia-device-plugin](https://github.com/NVIDIA/k8s-device-plugin) | minor | `0.15.1` -> `0.16.2` | | [node-feature-discovery](https://github.com/kubernetes-sigs/node-feature-discovery) | patch | `0.16.3` -> `0.16.4` | | [metallb](https://metallb.universe.tf) ([source](https://github.com/metallb/metallb)) | patch | `0.14.5` -> `0.14.8` | | csi-driver-smb | minor | `v1.14.0` -> `v1.15.0` | | csi-driver-nfs | minor | `v4.7.0` -> `v4.8.0` | | [cloudnative-pg](https://cloudnative-pg.io) ([source](https://github.com/cloudnative-pg/charts)) | minor | `0.21.5` -> `0.22.0` | | [cert-manager](https://cert-manager.io) ([source](https://github.com/cert-manager/cert-manager)) | patch | `v1.15.1` -> `v1.15.3` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. 🔧 This Pull Request updates lock files to use the latest dependency versions. --- ### Release Notes <details> <summary>openebs/dynamic-localpv-provisioner (localpv-provisioner)</summary> ### [`v4.1.0`](https://github.com/openebs/dynamic-localpv-provisioner/blob/HEAD/CHANGELOG.md#v410--2024-07-03) [Compare Source](https://github.com/openebs/dynamic-localpv-provisioner/compare/localpv-provisioner-4.0.0...localpv-provisioner-4.1.0) \=================== - Add pod priorityClassName to prevent race condition due to pod eviction ([#​182](https://github.com/openebs/dynamic-localpv-provisioner/pull/182),[@​bernardgut](https://github.com/bernardgut)) - Allow specifying additional labels to be applied to all helm chart resources ([#​183](https://github.com/openebs/dynamic-localpv-provisioner/pull/183),[@​laverya](https://github.com/laverya)) - feat(provisioner): update analytics pkg ([#​188](https://github.com/openebs/dynamic-localpv-provisioner/pull/188),[@​niladrih](https://github.com/niladrih)) - build: update base alpine image version to 3.20.1 ([#​189](https://github.com/openebs/dynamic-localpv-provisioner/pull/189),[@​niladrih](https://github.com/niladrih)) </details> <details> <summary>NVIDIA/gpu-operator (gpu-operator)</summary> ### [`v24.6.1`](https://github.com/NVIDIA/gpu-operator/releases/tag/v24.6.1): GPU Operator 24.6.1 Release [Compare Source](https://github.com/NVIDIA/gpu-operator/compare/v24.6.0...v24.6.1) https://docs.nvidia.com/datacenter/cloud-native/gpu-operator/24.6.1/index.html ### [`v24.6.0`](https://github.com/NVIDIA/gpu-operator/releases/tag/v24.6.0): GPU Operator 24.6.0 Release [Compare Source](https://github.com/NVIDIA/gpu-operator/compare/v24.3.0...v24.6.0) https://docs.nvidia.com/datacenter/cloud-native/gpu-operator/24.6.0/release-notes.html </details> <details> <summary>NVIDIA/k8s-device-plugin (nvidia-device-plugin)</summary> ### [`v0.16.2`](https://github.com/NVIDIA/k8s-device-plugin/blob/HEAD/CHANGELOG.md#v0162) [Compare Source](https://github.com/NVIDIA/k8s-device-plugin/compare/v0.16.1...v0.16.2) - Add CAP_SYS_ADMIN if volume-mounts list strategy is included (fixes [#​856](https://github.com/NVIDIA/k8s-device-plugin/issues/856)) - Remove unneeded DEVICE_PLUGIN_MODE envvar - Fix applying SELinux label for MPS ### [`v0.16.1`](https://github.com/NVIDIA/k8s-device-plugin/blob/HEAD/CHANGELOG.md#v0161) [Compare Source](https://github.com/NVIDIA/k8s-device-plugin/compare/v0.16.0...v0.16.1) - Bump nvidia-container-toolkit to v1.16.1 to fix a bug with CDI spec generation for MIG devices ### [`v0.16.0`](https://github.com/NVIDIA/k8s-device-plugin/blob/HEAD/CHANGELOG.md#v0160) [Compare Source](https://github.com/NVIDIA/k8s-device-plugin/compare/v0.15.1...v0.16.0) - Fixed logic of atomic writing of the feature file - Replaced `WithDialer` with `WithContextDialer` - Fixed SELinux context of MPS pipe directory. - Changed behavior for empty MIG devices to issue a warning instead of an error when the mixed strategy is selected - Added a a GFD node label for the GPU mode. - Update CUDA base image version to 12.5.1 </details> <details> <summary>kubernetes-sigs/node-feature-discovery (node-feature-discovery)</summary> ### [`v0.16.4`](https://github.com/kubernetes-sigs/node-feature-discovery/releases/tag/v0.16.4) [Compare Source](https://github.com/kubernetes-sigs/node-feature-discovery/compare/v0.16.3...v0.16.4) #### What's Changed This patch release contains improvements to the Helm chart, adding configurable liveness and readiness probes for all daemons and configurable revision history limit for the nfd-worker and nfd-topology-updater. - Helm: Add revision history limit for worker daemonset ([#​1797](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1797)) by [@​marquiz](https://github.com/marquiz) in [kubernetes-sigs/node-feature-discovery#1799 - go.mod: bump kubernetes to v1.30.3 by [@​marquiz](https://github.com/marquiz) in [kubernetes-sigs/node-feature-discovery#1805 - helm: add configurable liveness\&readiness probes by [@​marquiz](https://github.com/marquiz) in [kubernetes-sigs/node-feature-discovery#1808 - Add helm migration guide by [@​k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot) in [kubernetes-sigs/node-feature-discovery#1825 **Full Changelog**: kubernetes-sigs/node-feature-discovery@v0.16.3...v0.16.4 </details> <details> <summary>metallb/metallb (metallb)</summary> ### [`v0.14.8`](https://github.com/metallb/metallb/releases/tag/v0.14.8): v0.14.18 [Compare Source](https://github.com/metallb/metallb/compare/v0.14.7...v0.14.8) See the release notes for the details https://metallb.universe.tf/release-notes/#version-0-14-8 ### [`v0.14.7`](https://github.com/metallb/metallb/releases/tag/v0.14.7): v0.14.17 [Compare Source](https://github.com/metallb/metallb/compare/v0.14.6...v0.14.7) See the release notes for the details https://metallb.universe.tf/release-notes/#version-0-14-7 ### [`v0.14.6`](https://github.com/metallb/metallb/releases/tag/v0.14.6): v0.14.16 [Compare Source](https://github.com/metallb/metallb/compare/v0.14.5...v0.14.6) See the release notes for the details https://metallb.universe.tf/release-notes/#version-0-14-6 </details> <details> <summary>cloudnative-pg/charts (cloudnative-pg)</summary> ### [`v0.22.0`](https://github.com/cloudnative-pg/charts/releases/tag/cloudnative-pg-v0.22.0) [Compare Source](https://github.com/cloudnative-pg/charts/compare/cloudnative-pg-v0.21.6...cloudnative-pg-v0.22.0) CloudNativePG Operator Helm Chart #### What's Changed - Kyverno Chainsaw Test Suite by [@​itay-grudev](https://github.com/itay-grudev) in [cloudnative-pg/charts#341 - chore(deps): update sigstore/cosign-installer action to v3.6.0 by [@​renovate](https://github.com/renovate) in [cloudnative-pg/charts#347 - chore(deps): update kyverno/action-install-chainsaw action to v0.2.8 by [@​renovate](https://github.com/renovate) in [cloudnative-pg/charts#349 - Release cloudnative-pg-v0.22.0 by [@​github-actions](https://github.com/github-actions) in [cloudnative-pg/charts#352 **Full Changelog**: cloudnative-pg/charts@cloudnative-pg-v0.21.6...cloudnative-pg-v0.22.0 ### [`v0.21.6`](https://github.com/cloudnative-pg/charts/releases/tag/cloudnative-pg-v0.21.6) [Compare Source](https://github.com/cloudnative-pg/charts/compare/cloudnative-pg-v0.21.5...cloudnative-pg-v0.21.6) CloudNativePG Operator Helm Chart #### What's Changed - Add walStorage capability and remove gkeEnvironment conflict in cluster chart. by [@​rocket357](https://github.com/rocket357) in [cloudnative-pg/charts#312 - chore(deps): update actions/setup-python action to v5.1.1 by [@​renovate](https://github.com/renovate) in [cloudnative-pg/charts#330 - chore(deps): update docker/login-action action to v3.3.0 by [@​renovate](https://github.com/renovate) in [cloudnative-pg/charts#333 - chore: add support for `hostNetwork` in chart by [@​marckhair](https://github.com/marckhair) in [cloudnative-pg/charts#324 - feat(cloudnative-pg): Configuration of PodMonitor relabeling rules by [@​npdgm](https://github.com/npdgm) in [cloudnative-pg/charts#148 - fix: linter - trailing white spaces by [@​sxd](https://github.com/sxd) in [cloudnative-pg/charts#339 - Release cloudnative-pg-v0.21.6 by [@​github-actions](https://github.com/github-actions) in [cloudnative-pg/charts#340 #### New Contributors - [@​rocket357](https://github.com/rocket357) made their first contribution in [cloudnative-pg/charts#312 - [@​marckhair](https://github.com/marckhair) made their first contribution in [cloudnative-pg/charts#324 - [@​npdgm](https://github.com/npdgm) made their first contribution in [cloudnative-pg/charts#148 **Full Changelog**: cloudnative-pg/charts@cloudnative-pg-v0.21.5...cloudnative-pg-v0.21.6 </details> <details> <summary>cert-manager/cert-manager (cert-manager)</summary> ### [`v1.15.3`](https://github.com/cert-manager/cert-manager/releases/tag/v1.15.3) [Compare Source](https://github.com/cert-manager/cert-manager/compare/v1.15.2...v1.15.3) cert-manager is the easiest way to automatically manage certificates in Kubernetes and OpenShift clusters. **🔗 [See v1.15.0](https://github.com/cert-manager/cert-manager/releases/tag/v1.15.0) for more information about cert-manager 1.15 and read-before-upgrade info.** #### 📜 Changes since [`v1.15.2`](https://github.com/cert-manager/cert-manager/releases/tag/v1.15.2) ##### Bug or Regression - BUGFIX: the dynamic certificate source used by the webhook TLS server failed to detect a root CA approaching expiration, due to a calculation error. This will cause the webhook TLS server to fail renewing its CA certificate. Please upgrade before the expiration of this CA certificate is reached. ([#​7232](https://github.com/cert-manager/cert-manager/issues/7232), [@​cert-manager-bot](https://github.com/cert-manager-bot)) ### [`v1.15.2`](https://github.com/cert-manager/cert-manager/releases/tag/v1.15.2) [Compare Source](https://github.com/cert-manager/cert-manager/compare/v1.15.1...v1.15.2) cert-manager is the easiest way to automatically manage certificates in Kubernetes and OpenShift clusters. **🔗 [See v1.15.0](https://github.com/cert-manager/cert-manager/releases/tag/v1.15.0) for more information about cert-manager 1.15 and read-before-upgrade info.** #### 📜 Changes since [`v1.15.1`](https://github.com/cert-manager/cert-manager/releases/tag/v1.15.1) ##### Bug or Regression - BUGFIX `route53`: explicitly set the `aws-global` STS region which is now required by the `github.com/aws/aws-sdk-go-v2` library. ([#​7189](https://github.com/cert-manager/cert-manager/pull/7189), [`@cert-manager-bot`](https://github.com/cert-manager-bot)) - Bump `grpc-go` to fix `GHSA-xr7q-jx4m-x55m` ([#​7167](https://github.com/cert-manager/cert-manager/pull/7167), [`@SgtCoDFish`](https://github.com/SgtCoDFish)) - Fix Azure DNS causing panics whenever authentication error happens ([#​7188](https://github.com/cert-manager/cert-manager/pull/7188), [`@cert-manager-bot`](https://github.com/cert-manager-bot)) - Fix incorrect value and indentation of `endpointAdditionalProperties` in the `PodMonitor` template of the Helm chart ([#​7191](https://github.com/cert-manager/cert-manager/pull/7191), [`@inteon`](https://github.com/inteon)) - Fixes ACME HTTP01 challenge behavior when using Gateway API to prevent unbounded creation of `HTTPRoute` resources ([#​7186](https://github.com/cert-manager/cert-manager/pull/7186), [`@cert-manager-bot`](https://github.com/cert-manager-bot)) - Upgrade `golang` from `1.22.3` to `1.22.5` ([#​7165](https://github.com/cert-manager/cert-manager/pull/7165), [`@github-actions`](https://github.com/github-actions)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on monday" in timezone Europe/Amsterdam, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNiIsInVwZGF0ZWRJblZlciI6IjM4LjUxLjAiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIiLCJsYWJlbHMiOlsidXBkYXRlL2hlbG0vc3lzdGVtIl19--> --------- Signed-off-by: alfi0812 <43101280+alfi0812@users.noreply.github.com> Co-authored-by: alfi0812 <43101280+alfi0812@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in eks, the deployment is failing because of the webhook with the following error:
The fix would be to set
hostNetworktrue but it is not configurable in the chart.In addition to that, the
dnsPolicyneeds to be set toClusterFirstWithHostNetto givehostNetworkpods access to internal DNS.