Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mkFit JSON files for 12_1_0_pre4 #5

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

mmasciov
Copy link
Contributor

@mmasciov mmasciov commented Sep 30, 2021

Update of per-iteration JSON files for mkFit configuration, as per PR cms-sw/cmsdist#7349 and cms-sw/cmssw#35492

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmasciov (Mario Masciovecchio) for branch main.

@smuzaffar, @mrodozov, @iarspider, @cmsbuild, @slava77, @jpata can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@jpata
Copy link

jpata commented Oct 5, 2021

+reconstruction

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2021

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-601a1c/19402/summary.html
COMMIT: 8a881ca
CMSSW: CMSSW_12_1_X_2021-10-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/RecoTracker-MkFit/5/19402/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 05-Oct-2021 14:56:50 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'MC_AK8PFHT_v16'
   [2] Prefetching for module MkFitProducer/'hltIter0PFlowCkfTrackCandidatesMkFit'
   [3] Calling method for EventSetup module MkFitIterationConfigESProducer/'hltIter0PFlowTrackCandidatesMkFitConfig'
Exception Message:
A std::exception was thrown.
[json.exception.out_of_range.403] key 'm_backward_drop_seed_hits' not found
----- End Fatal Exception -------------------------------------------------

@jpata
Copy link

jpata commented Oct 5, 2021

test parameters:

@jpata
Copy link

jpata commented Oct 5, 2021

The test actually passed in the CMSSW PR.

@perrotta
Copy link

perrotta commented Oct 5, 2021

+1

  • To be merged together with #35492

@perrotta
Copy link

perrotta commented Oct 5, 2021

@smuzaffar let me merge this, together with #35492, as decided right now in the ORP: please let me know if there are issues that I overlooked

@perrotta
Copy link

perrotta commented Oct 5, 2021

merge

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2021

This pull request is fully signed and it will be integrated in one of the next main IBs (but tests are reportedly failing).

@smuzaffar
Copy link
Contributor

@perrotta thanks for merging it. Once data pr is merged then cmsdist PR is automatically open. In this case cmsdist PR is cms-sw/cmsdist#7361 . So cms-sw/cmsdist#7361 should also be merged in order to get these new data files. I am merging cms-sw/cmsdist#7361 now

@perrotta
Copy link

perrotta commented Oct 5, 2021

Thank you @smuzaffar !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants