Hcal DetIds/Digi DataFrames adjustments to be used with cuda #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to DataFormats/DetId updates for HcalDetid and HcalDigi - move the implementation to the header files - mark methods as `constexpr`
The final test is: - create an `HBHEDigiCollection`/`HFDigiCollection`/`HODigiCollection` on the host side and fill it - allocate space on the gpu - transfer to the gpu - run the kernel to compute some func per channel - transfer the results back to host - assert for each channel
fwyzard
force-pushed
the
vkhristenko/hcalhbhedf_constexpr_10_2_0_pre4
branch
from
7c28fdb
to
18418f6
Compare
fwyzard
added a commit
that referenced
this pull request
Jun 4, 2018
Update HcalDetids and HcalDigis to support CUDA similar to DataFormats/DetId: - move the implementation to the header files - mark methods as `constexpr` Add CUDA tests for HcalDetId and HcalDigi dataformats: - create an `HBHEDigiCollection`/`HFDigiCollection`/`HODigiCollection` on the host side and fill it - allocate space on the gpu - transfer to the gpu - run the kernel to compute some func per channel - transfer the results back to host - assert for each channel
fwyzard
added a commit
that referenced
this pull request
Jun 4, 2018
Update HcalDetids and HcalDigis to support CUDA similar to DataFormats/DetId: - move the implementation to the header files - mark methods as `constexpr` Add CUDA tests for HcalDetId and HcalDigi dataformats: - create an `HBHEDigiCollection`/`HFDigiCollection`/`HODigiCollection` on the host side and fill it - allocate space on the gpu - transfer to the gpu - run the kernel to compute some func per channel - transfer the results back to host - assert for each channel
fwyzard
added a commit
that referenced
this pull request
Jun 4, 2018
Update HcalDetids and HcalDigis to support CUDA similar to DataFormats/DetId: - move the implementation to the header files - mark methods as `constexpr` Add CUDA tests for HcalDetId and HcalDigi dataformats: - create an `HBHEDigiCollection`/`HFDigiCollection`/`HODigiCollection` on the host side and fill it - allocate space on the gpu - transfer to the gpu - run the kernel to compute some func per channel - transfer the results back to host - assert for each channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made by @vkhristenko - see #58 and cms-sw#23386 .