Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[G4] Update geant4 to 11.1.ref09 #8741

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

iarspider
Copy link
Contributor

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2023

A new Pull Request was created by @iarspider for branch IB/CMSSW_13_3_X/g4.

@iarspider, @smuzaffar, @aandvalenzuela can you please review it and eventually sign? Thanks.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2023

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91c52c/35096/summary.html
COMMIT: 5ba2056
CMSSW: CMSSW_13_3_GEANT4_X_2023-10-08-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8741/35096/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

make[1]: *** [CMakeFiles/Makefile2:339: G4HepEm/G4HepEmInit/CMakeFiles/g4HepEmInit.dir/all] Error 2
make[2]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/g4hepem/20230309-d0b39763fa2a7ece5d9d83ac328c2d89/build'
[ 85%] Built target g4HepEmDataJsonIO
make[1]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/g4hepem/20230309-d0b39763fa2a7ece5d9d83ac328c2d89/build'
make: *** [Makefile:136: all] Error 2
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.IfWU4K (%build)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+g4hepem+20230309-d0b39763fa2a7ece5d9d83ac328c2d89
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.IfWU4K (%build)


@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #8741 was updated.

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91c52c/35126/summary.html
COMMIT: cd19450
CMSSW: CMSSW_13_3_GEANT4_X_2023-10-08-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8741/35126/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

Requested to quit.
Requested to quit.
Requested to quit.
Requested to quit.
* The action "build-external+dd4hep+v01-25x-9fbb68fa953d5e575ca2fb6790b3bc97" was not completed successfully because Failed to build dd4hep. Log file in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/dd4hep/v01-25x-9fbb68fa953d5e575ca2fb6790b3bc97/log. Final lines of the log file:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/geant4/11.1.ref09-c0023944ba2eb756168daff2dc3d4dda/include/Geant4/G4Navigator.icc:300:20: error: invalid use of incomplete type 'class G4VTouchable'
300 |   touchableToUpdate->UpdateYourself( pPhysVol, &fHistory );
|                    ^~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/dd4hep/v01-25x-9fbb68fa953d5e575ca2fb6790b3bc97/dd4hep-v01-25x/DDG4/include/DDG4/Geant4Mapping.h:21,
from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/dd4hep/v01-25x-9fbb68fa953d5e575ca2fb6790b3bc97/dd4hep-v01-25x/DDG4/src/Geant4FastSimShowerModel.cpp:16:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/dd4hep/v01-25x-9fbb68fa953d5e575ca2fb6790b3bc97/dd4hep-v01-25x/DDG4/include/DDG4/Geant4VolumeManager.h:22:7: note: forward declaration of 'class G4VTouchable'


@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #8741 was updated.

@iarspider
Copy link
Contributor Author

please test for CMSSW_13_3_GEANT4_X/el8_amd64_gcc11

gcc version was moved to 12, but no IBs for that gcc version are available yet

@smuzaffar
Copy link
Contributor

lets wait for gcc12 geant4 IBs

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_3_X/g4 IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Pull request #8741 was updated.

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

+externals

looks good to go in GEANT4 IBs ( all tests passed)

@smuzaffar smuzaffar merged commit 8cc24bc into IB/CMSSW_13_3_X/g4 Oct 20, 2023
8 of 9 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_3_X/g4 IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@iarspider iarspider deleted the g4-11.1.ref09 branch October 20, 2023 13:38
@iarspider
Copy link
Contributor Author

@smuzaffar thanks!

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91c52c/35309/summary.html
COMMIT: 70651e5
CMSSW: CMSSW_13_3_GEANT4_X_2023-10-18-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8741/35309/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5825 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 61228 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3357400
  • DQMHistoTests: Total failures: 155656
  • DQMHistoTests: Total nulls: 269
  • DQMHistoTests: Total successes: 3201453
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -2.146 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.596 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 12634.0 ): 1.182 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 0.171 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.479 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -0.270 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): -3.346 KiB SiStrip/MechanicalView
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 17 / 48 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants