Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10_6_X + gcc700] Bump of cepgen version to 1.2.5 #9306

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

forthommel
Copy link
Contributor

@forthommel forthommel commented Jul 19, 2024

This PR bumps the CepGen version to the gcc7x upstream version 1.2.5.
This latter drops the support to various add-ons, and in particular ROOT interface (which allows to drop the CMake patch introduced earlier to cleans it up from the CepGenAddOns CMake directive).

FYI: @bbilin

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @forthommel for branch IB/CMSSW_10_6_X/gcc700.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 19, 2024

cms-bot internal usage

@forthommel forthommel changed the title [1.2.6 + gcc700] Bump of cepgen version to 1.2.5 [10_6_X + gcc700] Bump of cepgen version to 1.2.5 Jul 19, 2024
@bbilin
Copy link

bbilin commented Jul 19, 2024

@cmsbuild please test

@bbilin
Copy link

bbilin commented Jul 19, 2024

Also this involves a bugfix regarding missing status of particles in HepMC format.

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37ebfc/40494/summary.html
COMMIT: 20eb41f
CMSSW: CMSSW_10_6_X_2024-07-14-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9306/40494/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

* The action "build-cms+cmssw-tool-conf+45.0-a26f4d4c2f92b8e266fce489a3de784d" was not completed successfully because The following dependencies could not complete:
install-external+cepgen-toolfile+1.0-394757b94b1db1dca6a2d7feb49d8f29
* The action "build-external+cepgen-toolfile+1.0-394757b94b1db1dca6a2d7feb49d8f29" was not completed successfully because The following dependencies could not complete:
install-external+cepgen+1.2.5_gcc710-91f6d7e32a3f57a07244b02c07b36f0e
* The action "build-external+cepgen+1.2.5_gcc710-91f6d7e32a3f57a07244b02c07b36f0e" was not completed successfully because Failed to build cepgen. Log file in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc700/external/cepgen/1.2.5_gcc710-91f6d7e32a3f57a07244b02c07b36f0e/log. Final lines of the log file:
error: %patch without corresponding "Patch:" tag



@cmsbuild
Copy link
Contributor

Pull request #9306 was updated.

@forthommel
Copy link
Contributor Author

My bad! I forgot a leftover %patch instruction in the spec-file!

@bbilin
Copy link

bbilin commented Jul 19, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37ebfc/40496/summary.html
COMMIT: 59e977f
CMSSW: CMSSW_10_6_X_2024-07-14-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9306/40496/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215351
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 144 log files, 103 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

@cms-sw/orp-l2 , feel free to include it for 10.6.X IBs

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_6_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link

+1

@cmsbuild cmsbuild merged commit 1a861ee into cms-sw:IB/CMSSW_10_6_X/gcc700 Jul 23, 2024
9 checks passed
@forthommel forthommel deleted the patch-2 branch July 23, 2024 15:06
@forthommel
Copy link
Contributor Author

Thanks a lot, @bbilin, @smuzaffar, @rappoccio !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants