Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ROCm targets #9353

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Aug 8, 2024

Build HIP/ROCm code in CMSSW for:

  • Radeon Pro WX 8200/9100 (gfx900)
  • Radeon Pro W7800/W7900 (gfx1100)
  • Radeon Pro W7600 (gfx1102)
  • Instinct MI210/MI250 (gfx90a)

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2024

A new Pull Request was created by @fwyzard for branch IB/CMSSW_14_1_X/master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2024

cms-bot internal usage

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 8, 2024

test parameters:

  • full_cmssw = true
  • enable_test = gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 8, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6bd5c3/40838/summary.html
COMMIT: 7cc2199
CMSSW: CMSSW_14_1_X_2024-08-08-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9353/40838/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6bd5c3/40838/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6bd5c3/40838/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 146 lines from the logs
  • Reco comparison results: 156 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3422822
  • DQMHistoTests: Total failures: 302
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3422500
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -242.01100000000002 KiB( 44 files compared)
  • DQMHistoSizes: changed ( 23234.0,... ): -34.573 KiB MTD/ElectronIso
  • Checked 196 log files, 165 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 9, 2024

Looks good to me.

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar smuzaffar merged commit 0efe39c into cms-sw:IB/CMSSW_14_1_X/master Aug 12, 2024
13 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild cmsbuild mentioned this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants