Phase-2 only detector SIM collection in Run-3 workflows

[srimanob]

As discussed #42961, the Phase-2 only SIM collections appears in Run-3 workflow. This issue is to follow up in case we would like to implement a switch to turn-off collections, to avoid confusion.

[cmsbuild]

A new Issue was created by @srimanob Phat Srimanobhas.

@Dr15Jones, @antoniovilela, @sextonkennedy, @smuzaffar, @rappoccio, @makortel can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[srimanob]

assign simulation,geometry,upgrade

[cmsbuild]

New categories assigned: simulation,geometry,upgrade

@Dr15Jones,@AdrianoDee,@civanch,@civanch,@bsunanda,@makortel,@mdhildreth,@mdhildreth,@srimanob you have been requested to review this Pull request/Issue and eventually sign? Thanks

[antoniovilela]

Comment by Matti:
#42982 (comment)

[civanch]

the problem is a bit wider. We have Totem, Castor, sensitive part of HF, and now Phase-2 detectors. Sensitive detector classes are not created if they are not in geometry but all branches are there and OscarMTProducer offers the same for any type of jobs and geometries.

[bsunanda]

We also have detectors for simulating test beam scenarios. Maybe a solution to have special sets of qualifiers in the EventContent definition which will accept collections of one type of simulation: legacy, run2, run3, run4, TB, etc rather than accepting all collections from g4SimHits

…

________________________________ From: Vladimir Ivantchenko ***@***.***> Sent: 12 October 2023 14:04 To: cms-sw/cmssw ***@***.***> Cc: Sunanda Banerjee ***@***.***>; Mention ***@***.***> Subject: Re: [cms-sw/cmssw] Phase-2 only detector SIM collection in Run-3 workflows (Issue #42986) the problem is a bit wider. We have Totem, Castor, sensitive part of HF, and now Phase-2 detectors. Sensitive detector classes are not created if they are not in geometry but all branches are there and OscarMTProducer offers the same for any type of jobs and geometries. — Reply to this email directly, view it on GitHub<#42986 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOUFU2TZKW3LZFOCSILX66TQHANCNFSM6AAAAAA534K5GA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[civanch]

For me legacy==run2, would you agree?

[antoniovilela]

Thanks Sunanda, Vladimir.

One question is would it be feasible to add a flag in the OscarProducer indicating run1/2/3/4, or as you said legacy, run3 and run4, so you customize what you call by these periods?

[srimanob]

Will era or modifier work to identify all cases? I have no clue if testbeam need something special. I assume we don't have specific era/modifier for test beam.

[makortel]

Would it be feasible to make the sensitive detector builder classes that inherit from SensitiveDetectorMakerBase (that already call the esConsumes()/consumes()) to call the produces() for those data product types the corresponding sensitive detector produces the products? Then the set of data product branches would be correct automatically without any configuration changes.

The framework provides edm::ProducesCollector helper class (via producesCollector() function) that can be used analogously to edm::ConsumesCollector to collect the produces() information from helper classes.

[bsunanda]

Hi Matti, that may be a good solution. We can try it out.

…

________________________________ From: Matti Kortelainen ***@***.***> Sent: 13 October 2023 02:18 To: cms-sw/cmssw ***@***.***> Cc: Sunanda Banerjee ***@***.***>; Mention ***@***.***> Subject: Re: [cms-sw/cmssw] Phase-2 only detector SIM collection in Run-3 workflows (Issue #42986) Would it be feasible to make the sensitive detector builder classes that inherit from SensitiveDetectorMakerBase (that already call the esConsumes()/consumes()) to call the produces() for those data product types the corresponding sensitive detector produces the products? Then the set of data product branches would be correct automatically without any configuration changes. The framework provides edm::ProducesCollector helper class (via producesCollector() function) that can be used analogously to edm::ConsumesCollector to collect the produces() information from helper classes. — Reply to this email directly, view it on GitHub<#42986 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOWVOCDYMSTBEMT32O3X7BJSNANCNFSM6AAAAAA534K5GA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[civanch]

+1

[civanch]

@srimanob , this is already done and the issue may be closed.

[srimanob]

+Upgrade

[cmsbuild]

This issue is fully signed and ready to be closed.