Flow modulated CS subtraction for heavy ions

[stepobr]

Flow-modulated constituent subtraction for heavy ions. An option to the existing CSJetProducer. Takes into account azimuthal anisotropy of the underlying event.

@mandrenguyen @bi-ran

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30057/15770

• This PR adds an extra 36KB to repository

• Found files with invalid states:

  • RecoHI/HiJetAlgos/python/hiPFCandCleaner_cfi.py:
    • Added: 72a0a56, 84041f2
    • Deleted: 273940e
  • RecoHI/HiJetAlgos/plugins/HiPFCandCleaner.h:
    • Added: 72a0a56, 84041f2
    • Deleted: 273940e
  • RecoHI/HiJetAlgos/plugins/HiPFCandCleaner.cc:
    • Added: 72a0a56, 84041f2
    • Deleted: 273940e

[cmsbuild]

A new Pull Request was created by @stepobr (Stepan Obraztsov) for master.

It involves the following packages:

RecoHI/HiJetAlgos
RecoJets/Configuration
RecoJets/JetProducers

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @ahinzmann, @schoef, @jazzitup, @jdamgov, @yslai, @nhanvtran, @yenjie, @gkasieczka, @clelange, @kurtejung, @mariadalfonso, @mandrenguyen, @dgulhan, @seemasharmafnal, @yetkinyilmaz this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6707/console Started: 2020/05/30 14:45

[cmsbuild]

+1
Tested at: 8c0db1b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-561667/6707/summary.html
CMSSW: CMSSW_11_2_X_2020-05-29-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-561667/6707/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 60 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2780792
• DQMHistoTests: Total failures: 336
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2780406
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[cmsbuild]

Pull request #30057 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-21-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8190/console Started: 2020/07/21 19:06

[cmsbuild]

+1
Tested at: 968daf9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-561667/8190/summary.html
CMSSW: CMSSW_11_2_X_2020-07-21-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-561667/8190/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 72 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2525996
• DQMHistoTests: Total failures: 311
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2525638
• DQMHistoTests: Total skipped: 47
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 144 log files, 17 edm output root files, 34 DQM output files

[slava77]

+1

for #30057 968daf9

• code changes are in line with the PR description and the follow up review
• jenkins tests pass and comparisons with the baseline show differences in HI workflows in CS jet variables
• local test with 200 events in wf 158.0 and 140.56 confirm the expected behavior with more stats
  • CPU use is somewhat under control (based on wf 140.56; with rather central events): the new modules hiPuRho (36 ms/ev; a factor of about 100 faster than the earliest version as of e865781) and hiFJRhoFlowModulation (1.3 ms/ev) contribute somewhat negligibly to the total (of about 300 s/ev ); the last update in 968daf9 fully mitigated the compute performance in akCs4PFJets (based on a test done in 158.0, though).

plots posted in #30057 (comment) were confirmed to be OK/expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[silviodonato]

merge

[stepobr]

Many thanks for all the help!!!