-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop obsolete condDBv2 files #31127
Drop obsolete condDBv2 files #31127
Conversation
@cmsbuild, please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31127/17719
|
The tests are being triggered in jenkins.
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages: CalibTracker/SiPixelConnectivity @benkrikler, @christopheralanwest, @tocheng, @cmsbuild, @rekovic, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@@ -14,7 +14,7 @@ | |||
|
|||
#hptopo | |||
process.load("Configuration.StandardSequences.FrontierConditions_GlobalTag_condDBv2_cff") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since you are at it, you might as well drop this other obsolete piece:
https://github.com/cms-sw/cmssw/blob/master/Configuration/StandardSequences/python/FrontierConditions_GlobalTag_condDBv2_cff.py
which just does:
from Configuration.StandardSequences.FrontierConditions_GlobalTag_cff import *
+1 |
+1 |
+1 |
+1 |
+operations |
kind reminder @cms-sw/db-l2 @cms-sw/generators-l2 @cms-sw/l1-l2 |
just ignore them and merge ? |
+generators |
+1 |
merge |
PR description:
Delete the obsolete files for "condDBv2", and update the configurations that were still using them.
PR validation:
None.