Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store EW parameter weights in NanoAOD of W mass samples #31939

Merged
merged 3 commits into from
Oct 28, 2020

Conversation

kdlong
Copy link
Contributor

@kdlong kdlong commented Oct 26, 2020

PR description:

Explicitly stores the EW parameter weights in the NanoAOD for the W mass Drell-Yan and W MC samples. Adds 43 weights for the DYJetsToMuMu_M-50_TuneCP5_13TeV-powhegMiNNLO-pythia8-photos and 33 fro the W*JetsToMuNu_TuneCP5_13TeV-powhegMiNNLO-pythia8-photos samples. The weights include mV and sintheta variations that are essential to the analysis. No other samples are affected.

PR validation:

Confirmed that the weights are added correctly for these samples and that others are unaffected.

@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Oct 26, 2020
@kdlong kdlong changed the title Nano wmass ew weights Store EW parameter weights in NanoAOD of W mass samples Oct 26, 2020
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31939/19384

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31939/19390

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kdlong (Kenneth Long) for master.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @santocch, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @peruzzim, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mariadalfonso
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 27, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 6b03d69
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-643226/10307/summary.html
CMSSW: CMSSW_11_2_X_2020-10-26-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@mariadalfonso
Copy link
Contributor

assign generators

@cmsbuild
Copy link
Contributor

New categories assigned: generators

@alberto-sanchez,@SiewYan,@GurpreetSinghChahal,@mkirsano,@agrohsje you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-643226/10307/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2544110
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2544075
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@agrohsje
Copy link

+1

@santocch
Copy link

+1

@gouskos
Copy link
Contributor

gouskos commented Oct 28, 2020

+xpog

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1
@kdlong @cms-sw/xpog-l2
std::cout should be removed from the whole PhysicsTools/NanoAOD/plugins/GenWeightsTableProducer.cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants