-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mini-PR: Fix EcalBaseNumber::getCopyNumber behavior #31963
Mini-PR: Fix EcalBaseNumber::getCopyNumber behavior #31963
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31963/19419
|
A new Pull Request was created by @ghugo83 for master. It involves the following packages: Geometry/EcalCommonData @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
@smuzaffar - is it possible to request a custom |
what do you mean by custom runTheMatrix test? |
please test workflow runTheMatrix.py -l 11607.911 --what upgrade |
if you want to run an extra workflow then just request the tests by commenting |
|
please test workflow 11607.911 |
The tests are being triggered in jenkins.
|
@ianna , so right now this combination does not work. when you use |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@ianna @smuzaffar in case an upgrade test is needed, at present one needs to add it to the standard matrix, see https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_2026.py @ianna as far as I can see this PR mimics what done time ago for MTD (I took the baseNumber approach from ECAL) |
As mentioned in #31882 and emails, can just remove the namespace in addLevel in ECalSD instead of changing EcalBaseNumber::getCopyNumber behavior.