[PPS] Prompt calibration loop component for timing detector

[forthommel]

PR description:

With this PR, we introduce the timing calibration PCL module for PPS diamond detector.
As encountered elsewhere for other subdetectors PCLs, it consists of two DQM-derivated algorithmic components:

• a (parallelisable) worker casting CTPPSDiamondRecHit objects onto integrated timing distributions (leading time, time over threshold, time over threshold vs. leading time)
• a harvester collecting this run-based info to perform the calibration and store it onto a PPSTimingCalibration object to be stored as a DB payload. It currently allows to store a sqlite conditions object holding this information.

As a mean to perform an upstream selection of "interesting events" for this calibration, a new EDFilter hosted in HLT "special" collection is introduced. It allows to define a per-pot tracks multiplicity selection, as used in 2017-2018 diamond timing calibration procedure. This latter is used in a new ALCARECOPPSCalTrackBasedSel selection. Please note that the tracks multiplicity selection may evolve in a while as the trigger studies are still being performed for this latter.
Also, it currently used the (unfiltered) (CTPPS|Totem)*LocalTrack collections instead of the simpler CTPPSLocalTrackLite collection that already includes some quality selection.

Subsequently, a new WF, 1040.2, is introduced to test this calibration procedure on a 2017 sample (also used in pixels PCL), and the relvals collections are appended the new PPS streams.

PR validation:

Compiles, runs.

if this PR is a backport please specify the original PR and why you need to backport that PR: N/A

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

@fabferro, @jan-kaspar, @vavati

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33215/21652

• This PR adds an extra 224KB to repository

• Found files with invalid states:

  • CalibPPS/TimingCalibration/plugins/PPSTrackFilter.cc:
    • Added: 42961f7
    • Deleted: b8343c0

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Update HLT/HLT relval/Express/Prompt GTs #33206, Add customisation to make sure that upgrade WFs will cross LS in the short matrix  #32957, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983, Update GENSIM string for 11_3_X IB test #33090, Patatrack integration - Pixel workflows (12/N) #31854

[cmsbuild]

A new Pull Request was created by @forthommel (Laurent Forthomme) for master.

It involves the following packages:

CalibPPS/TimingCalibration
Configuration/AlCa
Configuration/EventContent
Configuration/PyReleaseValidation
Configuration/StandardSequences
HLTrigger/special

The following packages do not have a category, yet:

CalibPPS/TimingCalibration
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@malbouis, @yuanchao, @jordan-martins, @chayanit, @wajidalikhan, @fwyzard, @christopheralanwest, @srimanob, @kpedro88, @Martin-Grunewald, @silviodonato, @franzoni, @cmsbuild, @tlampen, @qliphy, @pohsun, @francescobrivio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @tocheng, @lecriste, @mmusich, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[srimanob]

Please test

[forthommel]

Thanks, @srimanob ! I realised some leftovers of the previous version of the filter were still there. Just cleaned them up in 9bef176.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33215/21656

• This PR adds an extra 148KB to repository

• Found files with invalid states:

  • CalibPPS/TimingCalibration/test/test_catch2_PPSTrackFilter.cc:
    • Added: 42961f7
    • Deleted: 9bef176
  • CalibPPS/TimingCalibration/test/BuildFile.xml:
    • Added: 42961f7
    • Deleted: 9bef176
  • CalibPPS/TimingCalibration/plugins/PPSTrackFilter.cc:
    • Added: 42961f7
    • Deleted: b8343c0
  • CalibPPS/TimingCalibration/test/test_catch2_main.cc:
    • Added: 42961f7
    • Deleted: 9bef176

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Update HLT/HLT relval/Express/Prompt GTs #33206, Add customisation to make sure that upgrade WFs will cross LS in the short matrix  #32957, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983, Update GENSIM string for 11_3_X IB test #33090, Patatrack integration - Pixel workflows (12/N) #31854

[cmsbuild]

Pull request #33215 was updated. @malbouis, @yuanchao, @jordan-martins, @chayanit, @wajidalikhan, @fwyzard, @christopheralanwest, @srimanob, @kpedro88, @Martin-Grunewald, @silviodonato, @franzoni, @cmsbuild, @tlampen, @qliphy, @pohsun, @francescobrivio, @fabiocos, @davidlange6 can you please check and sign again.

[forthommel]

...

[jan-kaspar]

Can PPS do anything more to ease the review of this long-open PR? Thanks!

[chayanit]

+1

[srimanob]

+Upgrade

This PR is to introduce the time calibration PCL for PPS diamond detector. Workflow 1041 ran fine, and produced files as expected by PPS.

[forthommel]

AlCa: @pohsun @tlampen @christopheralanwest @yuanchao @francescobrivio @malbouis
HLT: @Martin-Grunewald @fwyzard
Operations: @davidlange6 @franzoni @qliphy @silviodonato @fabiocos

[Martin-Grunewald]

+1

[yuanchao]

+1

[silviodonato]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

[forthommel]

Many many thanks to all the reviewers!