-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix runTheMatrix interactive and add tests. #40596
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40596/33850
|
A new Pull Request was created by @rovere (Marco Rovere) for master. It involves the following packages:
@bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-520e8e/30128/summary.html Comparison SummarySummary:
|
@cmsbuild please test Re-trigger the test after a week. |
Hi @rovere By the way, is the test considered to be OK in terms of resource? It seems to be a long printout, but maybe it is OK. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-520e8e/30283/summary.html Comparison SummarySummary:
|
Ciao @srimanob thanks for looking into this. |
+Upgrade |
Kindly ping @cms-sw/pdmv-l2 |
@cmsbuild please test Refresh the test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-520e8e/30563/summary.html Comparison SummarySummary:
|
+pdmv |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Recent addition of tests to
runTheMatrix
caused a crash while running it interactively. This PR fixes the crash.An additional test has also been added to periodically check the validity of the
--interactive
option ofrunTheMatrix
.PR validation:
runTheMatrix
still works.