Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include HcalPFCuts Rcd and update SiPixel Dynamic Inefficiency tags in MC GTs #41327

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Include HcalPFCuts Rcd and update SiPixel Dynamic Inefficiency tags in MC GTs #41327

merged 1 commit into from
Apr 13, 2023

Conversation

saumyaphor4252
Copy link
Contributor

PR description:

This PR:

  • Integrates the HcalPFCuts record in all the MC GTs introduced in HcalPFCuts database table and relevant infrastructure #41128 by updating the
    • Run1 and Run2 GTs with tag HcalPFCuts_2016_v1.0_mc
    • 2017 GTs with tag HcalPFCuts_2017_v1.0_mc
    • 2018 GTs with tag HcalPFCuts_2018_v1.0_mc
    • 2022 GTs with tag HcalPFCuts_2022_v1.0_mc
    • 2023, 2024 and Phase2 GTs with tag HcalPFCuts_2023_V1.0_mc
      as requested in this CMS Talk post[1].
  • In addition, it also updates the latest SiPixel dynamic Inefficincy tag SiPixelDynamicInefficiency_phase1_2023_v2_fix2 in the Phase1 2022, 2023 and 2024 GTs requested in this CMS Talk post [2].

[1] https://cms-talk.web.cern.ch/t/mc-newly-created-hcalpfcuts-mc-tags-submitted-to-13-1-x-mc-queues/22585
[2] https://cms-talk.web.cern.ch/t/request-creation-of-a-gt-with-preliminary-pixel-dynamic-inefficiency-settings/20385/15

GT Differences with the last ones are here:

PR validation:

GTs tested locally with runTheMatrix.py -l 5.1,8.0,9.0,25.0,101.0,140.0,50200.0,7.22,145.0,281.0,1325.516,11634.0,7.23,159.0,12434.0,12834.0,7.24,160.1 -j 8 --ibeos -j 8 --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but a partial backport with the SiPixel Dynamic Inefficiency GT updates will be followed up.

@cmsbuild cmsbuild added this to the CMSSW_13_1_X milestone Apr 12, 2023
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41327/35151

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @saumyaphor4252 (Saumya Phor) for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@saumyaphor4252
Copy link
Contributor Author

@cmsbuild, please test

@francescobrivio
Copy link
Contributor

FYI @abdoulline

@abdoulline
Copy link

Thanks!

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd11ba/31949/summary.html
COMMIT: 97ce865
CMSSW: CMSSW_13_1_X_2023-04-12-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41327/31949/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 7 lines from the logs
  • Reco comparison results: 2067 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3459609
  • DQMHistoTests: Total failures: 6188
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3453399
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 1 / 46 workflows

@tvami
Copy link
Contributor

tvami commented Apr 12, 2023

+alca

  • widespread changes, as expected from the redigitization using new DynEff payload

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

@saumyaphor4252 @tvami
In wf 11834 there are changes also in tracking quantities that should not depend on HCAL, eg:

image

Is it expected, or due to some known instability in that workflow?

@mmusich
Copy link
Contributor

mmusich commented Apr 13, 2023

Is it expected, or due to some known instability in that workflow?

Aren't we changing the pixel dynamic inefficiency here as well???

@perrotta
Copy link
Contributor

Is it expected, or due to some known instability in that workflow?

Aren't we changing the pixel dynamic inefficiency here as well???

Correct, thank you @mmusich
(I just woke up...)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ea1fba2 into cms-sw:master Apr 13, 2023
@saumyaphor4252 saumyaphor4252 mentioned this pull request Apr 13, 2023
Merged
@cmsbuild cmsbuild mentioned this pull request Apr 13, 2023
Closed
@makortel makortel mentioned this pull request Apr 13, 2023
Closed
@makortel
Copy link
Contributor

Seems that this PR caused HcalPFCuts_unittest unit test to fail in the IBs, see #41338

@perrotta perrotta mentioned this pull request May 5, 2023
Merged
@saumyaphor4252 saumyaphor4252 deleted the alca-Include_HcalPFCutsRcd_in_MC_GTs branch October 13, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved code-checks-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_13_1_X
Development

Successfully merging this pull request may close these issues.
8 participants
@saumyaphor4252 @cmsbuild @francescobrivio @abdoulline @tvami @perrotta @mmusich @makortel