Phase2-hgx346Z Modify the tester for parameter and a few scripts to test HGCal geometry #43039

bsunanda · 2023-10-17T14:31:38Z

PR description:

Modify the tester for parameter and a few scripts to test HGCal geometry

PR validation:

Use the test code to dump parameters

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

cmsbuild · 2023-10-17T14:38:17Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43039/37222

This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43039/37222/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43039/37222/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2023-10-17T14:53:20Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43039/37223

This PR adds an extra 20KB to repository

bsunanda · 2023-10-17T15:11:33Z

@cmsbuild Please test

cmsbuild · 2023-10-17T15:11:58Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Geometry/HGCalCommonData (geometry, upgrade)

@Dr15Jones, @AdrianoDee, @civanch, @srimanob, @mdhildreth, @bsunanda, @makortel can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2023-10-17T17:13:59Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e79883/35229/summary.html
COMMIT: cfe57a9
CMSSW: CMSSW_13_3_X_2023-10-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43039/35229/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

136.793

----- Begin Fatal Exception 17-Oct-2023 17:54:38 CEST-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/data/Run2017C/DoubleEG/RAW/v1/000/301/998/00000/0073E73C-B68C-E711-9BF8-02163E019B6C.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://cms-xrd-global.cern.ch//eos/cms/store/data/Run2017C/DoubleEG/RAW/v1/000/301/998/00000/0073E73C-B68C-E711-9BF8-02163E019B6C.root
      [b] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/data/Run2017C/DoubleEG/RAW/v1/000/301/998/00000/0073E73C-B68C-E711-9BF8-02163E019B6C.root
      [c] Input file root://xrootd-cms.infn.it//store/data/Run2017C/DoubleEG/RAW/v1/000/301/998/00000/0073E73C-B68C-E711-9BF8-02163E019B6C.root could not be opened.
      [d] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/data/Run2017C/DoubleEG/RAW/v1/000/301/998/00000/0073E73C-B68C-E711-9BF8-02163E019B6C.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.�
' (errno=3011, code=400). No additional data servers were found.
      [e] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/data/Run2017C/DoubleEG/RAW/v1/000/301/998/00000/0073E73C-B68C-E711-9BF8-02163E019B6C.root?tried=+1213xrootd-cms-redir-int.cr.cnaf.infn.it,&xrdcl.requuid=91f378a6-99c9-4964-8ff0-bcadd7615468
      [f] Problematic data server: cms-xrd-global.cern.ch:1094
      [g] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

136.874

----- Begin Fatal Exception 17-Oct-2023 17:54:42 CEST-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/data/Run2018C/EGamma/RAW/v1/000/319/450/00000/084198F2-E583-E811-AE82-FA163E0AD27F.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://cms-xrd-global.cern.ch//eos/cms/store/data/Run2018C/EGamma/RAW/v1/000/319/450/00000/084198F2-E583-E811-AE82-FA163E0AD27F.root
      [b] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/data/Run2018C/EGamma/RAW/v1/000/319/450/00000/084198F2-E583-E811-AE82-FA163E0AD27F.root
      [c] Input file root://xrootd-cms.infn.it//store/data/Run2018C/EGamma/RAW/v1/000/319/450/00000/084198F2-E583-E811-AE82-FA163E0AD27F.root could not be opened.
      [d] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/data/Run2018C/EGamma/RAW/v1/000/319/450/00000/084198F2-E583-E811-AE82-FA163E0AD27F.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.�
' (errno=3011, code=400). No additional data servers were found.
      [e] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/data/Run2018C/EGamma/RAW/v1/000/319/450/00000/084198F2-E583-E811-AE82-FA163E0AD27F.root?tried=+1213llrxrd-redir.in2p3.fr,&xrdcl.requuid=c9c0124f-1451-42bd-94a5-ad34c3d37004
      [f] Problematic data server: cms-xrd-global.cern.ch:1094
      [g] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

136.88811

----- Begin Fatal Exception 17-Oct-2023 17:55:49 CEST-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/data/Run2018D/JetHT/AOD/12Nov2019_UL2018-v4/110007/02F69212-64ED-6B4B-BAC4-D9C2D53C8C57.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://cms-xrd-global.cern.ch//eos/cms/store/data/Run2018D/JetHT/AOD/12Nov2019_UL2018-v4/110007/02F69212-64ED-6B4B-BAC4-D9C2D53C8C57.root
      [b] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/data/Run2018D/JetHT/AOD/12Nov2019_UL2018-v4/110007/02F69212-64ED-6B4B-BAC4-D9C2D53C8C57.root
      [c] Input file root://xrootd-cms.infn.it//store/data/Run2018D/JetHT/AOD/12Nov2019_UL2018-v4/110007/02F69212-64ED-6B4B-BAC4-D9C2D53C8C57.root could not be opened.
      [d] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/data/Run2018D/JetHT/AOD/12Nov2019_UL2018-v4/110007/02F69212-64ED-6B4B-BAC4-D9C2D53C8C57.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.�
' (errno=3011, code=400). No additional data servers were found.
      [e] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/data/Run2018D/JetHT/AOD/12Nov2019_UL2018-v4/110007/02F69212-64ED-6B4B-BAC4-D9C2D53C8C57.root?tried=+1213llrxrd-redir.in2p3.fr,&xrdcl.requuid=95dbe0e8-bebf-4f5b-9302-71ef8415a8c8
      [f] Problematic data server: cms-xrd-global.cern.ch:1094
      [g] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

4.414.41_RunTau2012A/step2_RunTau2012A.log
4.454.45_RunJet2012A/step2_RunJet2012A.log

AddOn Tests

hlt_data_Fake2

----- Begin Fatal Exception 17-Oct-2023 17:55:50 CEST-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://cms-xrd-global.cern.ch//eos/cms/store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root
      [b] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root
      [c] Input file root://xrootd-cms.infn.it//store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root could not be opened.
      [d] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.�
' (errno=3011, code=400). No additional data servers were found.
      [e] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root?tried=+1213xrootd-cms-redir-int.cr.cnaf.infn.it,&xrdcl.requuid=e5103c1f-dcd0-412c-81d7-ba7809402330
      [f] Problematic data server: cms-xrd-global.cern.ch:1094
      [g] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

hlt_data_Fake2

----- Begin Fatal Exception 17-Oct-2023 17:55:57 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling File::sysopen()
Exception Message:
Failed to open the file 'RelVal_Raw_Fake2_DATA.root'
   Additional Info:
      [a] Input file file:RelVal_Raw_Fake2_DATA.root could not be opened.
      [b] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------

hlt_data_Fake2

----- Begin Fatal Exception 17-Oct-2023 17:56:31 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling File::sysopen()
Exception Message:
Failed to open the file 'RelVal_Raw_Fake2_DATA.root'
   Additional Info:
      [a] Input file file:RelVal_Raw_Fake2_DATA.root could not be opened.
      [b] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------

bsunanda · 2023-10-18T04:38:33Z

@cmsbuild Please test

cmsbuild · 2023-10-18T08:07:18Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e79883/35237/summary.html
COMMIT: cfe57a9
CMSSW: CMSSW_13_3_X_2023-10-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43039/35237/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 11 lines to the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3357400
DQMHistoTests: Total failures: 9
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3357369
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

bsunanda · 2023-10-18T12:03:02Z

+geometry

srimanob · 2023-10-18T12:44:45Z

+Upgrade

cmsbuild · 2023-10-18T12:45:07Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2023-10-19T15:30:08Z

+1

Modify the tester for parameter and a few scripts to test HGCal geometry

21e5b70

cmsbuild added this to the CMSSW_13_3_X milestone Oct 17, 2023

cmsbuild added geometry-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending labels Oct 17, 2023

cmsbuild added code-checks-rejected and removed code-checks-pending labels Oct 17, 2023

Code check

cfe57a9

cmsbuild added code-checks-pending and removed code-checks-rejected labels Oct 17, 2023

cmsbuild added tests-started code-checks-approved and removed tests-pending code-checks-pending labels Oct 17, 2023

cmsbuild added tests-rejected and removed tests-started labels Oct 17, 2023

cmsbuild mentioned this pull request Oct 17, 2023

Phase2-hgx346A Next step toward calibration cell collection for HGCal in the next version of HGCal geometry #43045

Closed

cmsbuild added tests-started and removed tests-rejected labels Oct 18, 2023

cmsbuild removed the tests-started label Oct 18, 2023

cmsbuild added the tests-approved label Oct 18, 2023

cmsbuild added geometry-approved and removed geometry-pending labels Oct 18, 2023

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Oct 18, 2023

cmsbuild added orp-approved and removed orp-pending labels Oct 19, 2023

cmsbuild merged commit 8c34d1f into cms-sw:master Oct 19, 2023
11 checks passed

This was referenced Oct 19, 2023

Update CUDA to support Pascal, Volta, Turing, Ampere and Lovelace GPUs cms-sw/cmsdist#8767

Merged

[do not merge][ASAN] Build with -O0 flag cms-sw/cmsdist#8761

Closed

clhep: Build with c++17 i.e. default std used for building cmssw cms-sw/cmsdist#8772

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase2-hgx346Z Modify the tester for parameter and a few scripts to test HGCal geometry #43039

Phase2-hgx346Z Modify the tester for parameter and a few scripts to test HGCal geometry #43039

bsunanda commented Oct 17, 2023

cmsbuild commented Oct 17, 2023

cmsbuild commented Oct 17, 2023

bsunanda commented Oct 17, 2023

cmsbuild commented Oct 17, 2023

cmsbuild commented Oct 17, 2023

bsunanda commented Oct 18, 2023

cmsbuild commented Oct 18, 2023

bsunanda commented Oct 18, 2023

srimanob commented Oct 18, 2023

cmsbuild commented Oct 18, 2023

rappoccio commented Oct 19, 2023

Phase2-hgx346Z Modify the tester for parameter and a few scripts to test HGCal geometry #43039

Phase2-hgx346Z Modify the tester for parameter and a few scripts to test HGCal geometry #43039

Conversation

bsunanda commented Oct 17, 2023

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Oct 17, 2023

cmsbuild commented Oct 17, 2023

bsunanda commented Oct 17, 2023

cmsbuild commented Oct 17, 2023

cmsbuild commented Oct 17, 2023

RelVals

RelVals-INPUT

AddOn Tests

bsunanda commented Oct 18, 2023

cmsbuild commented Oct 18, 2023

Comparison Summary

bsunanda commented Oct 18, 2023

srimanob commented Oct 18, 2023

cmsbuild commented Oct 18, 2023

rappoccio commented Oct 19, 2023