Add the ASSERT_DEVICE_MATCHES_HOST_COLLECTION macro

[fwyzard]

PR description:

Add a macro to check that the portable device collection for the host device is the same as the portable host collection.

Add tests from the event data and event setup portable collections.

PR validation:

The code compiles correctly, including the new static assertions.

[fwyzard]

please test

[fwyzard]

Should be OK for me.
@makortel, I let you review and sign this (or tell me to go ahead).

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43041/37227

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DataFormats/Portable/interface/alpaka/PortableCollection.h modified in PR(s): Add support to multi layout portable collections (any number) #40285
  • File DataFormats/PortableTestObjects/interface/alpaka/TestDeviceCollection.h modified in PR(s): Add support to multi layout portable collections (any number) #40285

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

• DataFormats/Portable (heterogeneous)
• DataFormats/PortableTestObjects (heterogeneous)
• HeterogeneousCore/AlpakaTest (heterogeneous)

@fwyzard, @makortel can you please review it and eventually sign? Thanks.
@rovere, @makortel, @missirol this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[fwyzard]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43041/37230

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DataFormats/Portable/interface/alpaka/PortableCollection.h modified in PR(s): Add support to multi layout portable collections (any number) #40285
  • File DataFormats/PortableTestObjects/interface/alpaka/TestDeviceCollection.h modified in PR(s): Add support to multi layout portable collections (any number) #40285

[cmsbuild]

Pull request #43041 was updated. @makortel, @fwyzard can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d39bea/35231/summary.html
COMMIT: f0cc419
CMSSW: CMSSW_13_3_X_2023-10-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43041/35231/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 4 lines to the logs
• Reco comparison results: 2982 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3357400
• DQMHistoTests: Total failures: 6123
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3351255
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: found differences in 1 / 48 workflows

[makortel]

Comparison differences are related to #35109

[makortel]

+heterogeneous

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[fwyzard]

@cms-sw/orp-l2 could you merge this in master ?
We have a few follow up PRs that depend on it.

[antoniovilela]

+1