Minor CLUE3D optimization

[bfonta]

Minor optimization of CLUE3D:

• remove a redundant if...else statement (the else reflects what was previously done in the initialization)
• move the same layer check before calculating distances with isReachable(); this saves a few instructions in each cluster iteration

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43050/37249

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @bfonta (Bruno Alves) for master.

It involves the following packages:

• RecoHGCal/TICL (upgrade, reconstruction)

@mandrenguyen, @AdrianoDee, @srimanob, @jfernan2, @cmsbuild can you please review it and eventually sign? Thanks.
@forthommel, @rovere, @felicepantaleo, @youyingli, @sameasy, @hatakeyamak, @apsallid, @sobhatta, @ebrondol, @lecriste, @missirol this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[srimanob]

@cmsbuild please test

[felicepantaleo]

assign hgcal-dpg

[cmsbuild]

New categories assigned: hgcal-dpg

@rovere,@cseez,@pfs,@felicepantaleo you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-caaa61/35261/summary.html
COMMIT: cde16c7
CMSSW: CMSSW_13_3_X_2023-10-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43050/35261/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3357400
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3357369
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[felicepantaleo]

enable profiling

[felicepantaleo]

@cmsbuild please test

[jfernan2]

+1
It would be nice to have checked timing in this PR but igprof test is broken: #43166

[smuzaffar]

Milestone for this pull request has been moved to CMSSW_14_0_X.Please open a backport if it should also go in to CMSSW_13_3_X.

[srimanob]

@cmsbuild please test

Re-trigger the test after 3 weeks.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-caaa61/35753/summary.html
COMMIT: cde16c7
CMSSW: CMSSW_14_0_X_2023-11-11-1100/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43050/35753/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 9 lines from the logs
• Reco comparison results: 16 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3363028
• DQMHistoTests: Total failures: 1400
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3361606
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[srimanob]

+Upgrade

[jfernan2]

+1

[felicepantaleo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1