Skip EcalRawData collection in ECAL DQM in GPU WFs

[alejands]

PR description:

ECAL DQM plots were showing up empty in GPU WFs in the most recent CMSSW IB releases. This was due to the introduction of a dummy EcalRawData collection in PR #42844, which was done in order to get rid of the error messages in issue #42720.

The problem is that most ECAL DQM tasks implement a filterRunType() function that uses EcalRawData to determine whether or not the task should run. It appears that for MC the run type is set to -1 (at least on GPUs), which is not a defined run type. This means that all tasks with a filterRunType() function are not scheduled to run.

The solution implemented is to skip EcalRawData using the new skipCollections parameter introduced in #42848. This is done using the gpu modifier to skip the collection for all GPU WFs, not just those used for ECAL GPU validation.

This is only to be used as long as the GPU unpacker unpacks a dummy EcalRawData collection.

It would be great if this could be integrated before 13_3_0_pre4 gets cut.

PR validation:

Validated on WF 12434.513. Plots are now filled as expected.

runTheMatrix.py --what gpu -l 12434.513

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43058/37260

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @alejands (Alejandro Sanchez) for master.

It involves the following packages:

• DQM/EcalMonitorTasks (dqm)

@syuvivida, @rvenditti, @antoniovagnerini, @nothingface0, @tjavaid, @cmsbuild can you please review it and eventually sign? Thanks.
@argiro, @rchatter, @thomreis, @ReyerBand, @wang0jin this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[alejands]

Could you please run the tests with GPU enabled?

[thomreis]

type ecal

[thomreis]

enable gpu

[thomreis]

please test

[thomreis]

type bugfix

[cmsbuild]

-1

Failed Tests: RelVals-GPU
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a9041/35273/summary.html
COMMIT: 2eaa8a0
CMSSW: CMSSW_13_3_X_2023-10-18-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43058/35273/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-GPU

• 12434.58712434.587_TTbar_14TeV+2023_Patatrack_AllTripletsGPU_Validation/step2_TTbar_14TeV+2023_Patatrack_AllTripletsGPU_Validation.log

Comparison Summary

Summary:

• You potentially added 6 lines to the logs
• Reco comparison results: 22 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3357400
• DQMHistoTests: Total failures: 1067
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3356311
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[thomreis]

please test

[thomreis]

please abort

[thomreis]

please test

Trying again.

[thomreis]

please test with cms-sw/cmsdist#8767

[cmsbuild]

-1

Failed Tests: GpuUnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a9041/35307/summary.html
COMMIT: 2eaa8a0
CMSSW: CMSSW_13_3_X_2023-10-19-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43058/35307/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Unit Tests

I found 1 errors in the following unit tests:

---> test testTFVisibleDevicesCUDA had ERRORS

Comparison Summary

Summary:

• You potentially removed 5 lines from the logs
• Reco comparison results: 24 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3357400
• DQMHistoTests: Total failures: 1067
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3356311
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• You potentially added 32 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 52 differences found in the comparisons
• DQMHistoTests: Total files compared: 2
• DQMHistoTests: Total histograms compared: 19678
• DQMHistoTests: Total failures: 1666
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 18012
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 1 files compared)
• Checked 6 log files, 6 edm output root files, 2 DQM output files
• TriggerResults: found differences in 1 / 1 workflows

[thomreis]

Hi @fwyzard is this GPU unit test error related to cms-sw/cmsdist#8767 ?

[fwyzard]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a9041/35333/summary.html
COMMIT: 2eaa8a0
CMSSW: CMSSW_13_3_X_2023-10-21-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43058/35333/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 6 lines to the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3357400
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3357369
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 3
• DQMHistoTests: Total histograms compared: 39740
• DQMHistoTests: Total failures: 1891
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 37849
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
• Checked 8 log files, 10 edm output root files, 3 DQM output files
• TriggerResults: no differences found

[thomreis]

The failing GPU tests are expected. The reference has only empty histograms as explained in the description and this PR fixes this.

[thomreis]

Hi @cms-sw/dqm-l2 is this PR OK for you?

[tjavaid]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1