Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include HcalPFCuts Rcd in Run2,3 offline data GTs #43095

Conversation

saumyaphor4252
Copy link
Contributor

PR description:

The PR updates the Run-2 and Run-3 data GTs to include the missing Hcal PF Cuts Record recognized in [1] with the following tags:

  • HcalPFCuts_v1.0_hlt for all HLT/Express/Prompt like GTs
  • HcalPFCuts_v1.0_offline for all offline GTs

from the request/suggestion in [2]. Detailed CMS Talk posts for this are [3] [4].

[1] #43025
[2] #43025 (comment)
[3] https://cms-talk.web.cern.ch/t/mc-newly-created-hcalpfcuts-mc-tags-submitted-to-13-1-x-mc-queues/22585/3
[4] https://cms-talk.web.cern.ch/t/queue-132x-data-queues-for-pp-ref-and-hi-data-taking/28067

GT Differences

PR validation:

Tested successfully with

  • runTheMatrix.py -l 136.731,136.793136.874,140.53,4.53,139.001,1000.0,1000.1 -j 8 --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43095/37333

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @saumyaphor4252 (Saumya Phor) for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@perrotta, @cmsbuild, @consuegs, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @tocheng, @fabiocos, @yuanchao, @mmusich, @rsreds this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@saumyaphor4252
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed9b5f/35372/summary.html
COMMIT: ea1f075
CMSSW: CMSSW_13_3_X_2023-10-23-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43095/35372/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 7 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3357400
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3357372
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@saumyaphor4252
Copy link
Contributor Author

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@saumyaphor4252
Copy link
Contributor Author

@cms-sw/orp-l2 We have another PR lined up after this. Can we have this merged in the next IB? Thanks!

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a05e5a4 into cms-sw:master Oct 26, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants