Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argparse migration for PhysicsTools and FWLite #43102

Merged
merged 7 commits into from
Oct 27, 2023

Conversation

kpedro88
Copy link
Contributor

PR description:

Followup to #43042. Probably the last one of these I'll have time to do.

PR validation:

Ran each script to ensure it still works. Unit tests pass.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Unlikely to be backported.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43102/37343

  • This PR adds an extra 44KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

  • DataFormats/FWLite (core)
  • PhysicsTools/FWLite (analysis)
  • PhysicsTools/NanoAOD (xpog)
  • PhysicsTools/NanoAODTools (xpog)
  • PhysicsTools/PythonAnalysis (analysis)
  • PhysicsTools/TagAndProbe (analysis)
  • PhysicsTools/Utilities (analysis)

@Dr15Jones, @simonepigazzini, @smuzaffar, @cmsbuild, @tvami, @makortel, @vlimant can you please review it and eventually sign? Thanks.
@rovere, @wddgit, @clelange, @lenzip, @gpetruc, @missirol, @makortel, @AnnikaStein this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-585fe4/35392/summary.html
COMMIT: 831b0fa
CMSSW: CMSSW_13_3_X_2023-10-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43102/35392/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 22 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3357400
  • DQMHistoTests: Total failures: 1067
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3356311
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@vlimant
Copy link
Contributor

vlimant commented Oct 25, 2023

+1

@makortel
Copy link
Contributor

Comparison differences are related to #39803

@makortel
Copy link
Contributor

+core

@tvami
Copy link
Contributor

tvami commented Oct 25, 2023

+analysis

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fb0c11b into cms-sw:master Oct 27, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants