-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-gex173 Make 2 changes: eta sizes for GE21; Size of Tracker volume to touch CALO and BeamPipe volumes on either side #43133
Conversation
…ALO and BeamPipe volumes on either side
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43133/37404
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@AdrianoDee, @makortel, @rappoccio, @srimanob, @davidlange6, @mdhildreth, @fabiocos, @Dr15Jones, @civanch, @antoniovilela, @bsunanda, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Comparison SummarySummary:
|
@cmsbuild Please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Comparison SummarySummary:
|
@srimanob Please approve this PR |
test parameters:
|
@cmsbuild please test Remind that everytime we touch or add geometries, we need to trigger the test on specific geometries if they does not run by default. |
@bsunanda @srimanob concerning the Geant4 navigation behaviour, #43142 takes care of this possible change. On top of this, I realize that I've never paid attention to the default valuie for a given geometry, for FastTiming it would be better to set it to 16 in
It could be done in this PR, or I can do it afterwards. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f53287/35497/summary.html Comparison SummarySummary:
|
@bsunanda just to be sure: could you confirm that the only CMS geometry with 3D split sensors left in CMSSW will be T35/D102? |
@srimanob please sign this |
@emiglior @bartonaz @Raffaella07 Yes it is the only one. The earlier D100 is moved to D102 and D101 is moved to D103. This is to allow D98 to become D100 with the correction and D99 to become D101. |
+Upgrade New/adjusted workflows run fine. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
Adapt tklayout to modification introduced in cms-sw/cmssw#43007 and cms-sw/cmssw#43133
PR description:
Make 2 changes: eta sizes for GE21 and size of Tracker volume to touch CALO and BeamPipe volumes on either side. Modify the scenarios 2026D100 and 2026D101; rename them as 2026D102 and 2026D103. Modify the scenarios 2026D98 and 2026D99 with the changes in muon and tracker region and name them 2026D100 and 2026D101. Also, provide the workflows for all these new scenarios.
PR validation:
Checked the overlaps in the new 4 scenarios
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Nothing special. Only new scenarios are added - the workflows are not yet defined