Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-gex173 Make 2 changes: eta sizes for GE21; Size of Tracker volume to touch CALO and BeamPipe volumes on either side #43133

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Oct 27, 2023

PR description:

Make 2 changes: eta sizes for GE21 and size of Tracker volume to touch CALO and BeamPipe volumes on either side. Modify the scenarios 2026D100 and 2026D101; rename them as 2026D102 and 2026D103. Modify the scenarios 2026D98 and 2026D99 with the changes in muon and tracker region and name them 2026D100 and 2026D101. Also, provide the workflows for all these new scenarios.

PR validation:

Checked the overlaps in the new 4 scenarios

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special. Only new scenarios are added - the workflows are not yet defined

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43133/37404

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Configuration/Geometry (geometry, upgrade)
  • Configuration/StandardSequences (operations)
  • Geometry/CMSCommonData (geometry, upgrade)
  • Geometry/MuonCommonData (geometry)
  • Geometry/TrackerCommonData (geometry)
  • SimG4Core/PrintGeomInfo (simulation)

@AdrianoDee, @makortel, @rappoccio, @srimanob, @davidlange6, @mdhildreth, @fabiocos, @Dr15Jones, @civanch, @antoniovilela, @bsunanda, @cmsbuild can you please review it and eventually sign? Thanks.
@venturia, @ptcox, @makortel, @sameasy, @mtosi, @GiacomoSguazzoni, @VourMa, @missirol, @ghugo83, @Martin-Grunewald, @JanFSchulte, @rovere, @dgulhan, @mmusich, @slomeo, @fabiocos, @felicepantaleo, @vargasa, @VinInn this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f53287/35458/summary.html
COMMIT: b8e1914
CMSSW: CMSSW_13_3_X_2023-10-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43133/35458/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 4.764.76_ZMuSkim2012D/step2_ZMuSkim2012D.log

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3357400
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3357375
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f53287/35462/summary.html
COMMIT: b8e1914
CMSSW: CMSSW_13_3_X_2023-10-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43133/35462/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 4.764.76_ZMuSkim2012D/step2_ZMuSkim2012D.log

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 24 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3357400
  • DQMHistoTests: Total failures: 1067
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3356311
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@bsunanda
Copy link
Contributor Author

@srimanob Please approve this PR

@srimanob
Copy link
Contributor

test parameters:

  • workflows = 25634.0,26034.0,26434.0,26834.0
  • relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,identity,ged,machine,premix,nano,gpu,2017,2026

@srimanob
Copy link
Contributor

@cmsbuild please test

Remind that everytime we touch or add geometries, we need to trigger the test on specific geometries if they does not run by default.

@srimanob
Copy link
Contributor

FYI
@emiglior for new trackers
@fabiocos for updating MTD
@cms-sw/muon-dpg-l2 for updating muon geometry

@fabiocos
Copy link
Contributor

@bsunanda @srimanob concerning the Geant4 navigation behaviour, #43142 takes care of this possible change. On top of this, I realize that I've never paid attention to the default valuie for a given geometry, for FastTiming it would be better to set it to 16 in

It could be done in this PR, or I can do it afterwards.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f53287/35497/summary.html
COMMIT: a4206eb
CMSSW: CMSSW_13_3_X_2023-10-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43133/35497/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 14 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3362691
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3362657
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emiglior
Copy link
Contributor

@bsunanda just to be sure: could you confirm that the only CMS geometry with 3D split sensors left in CMSSW will be T35/D102?
@bartonaz @Raffaella07

@bsunanda
Copy link
Contributor Author

bsunanda commented Nov 1, 2023

@srimanob please sign this

@bsunanda
Copy link
Contributor Author

bsunanda commented Nov 1, 2023

@emiglior @bartonaz @Raffaella07 Yes it is the only one. The earlier D100 is moved to D102 and D101 is moved to D103. This is to allow D98 to become D100 with the correction and D99 to become D101.

@srimanob
Copy link
Contributor

srimanob commented Nov 1, 2023

+Upgrade

New/adjusted workflows run fine.

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants