Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of TauWPThreshold without need to catch exceptions [14_0_X] #43909

Merged

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Feb 8, 2024

PR description:

As title says, this PR implements parsing of threshold values in the TauWPThreshold class using function which does not require catching exceptions. Namely, it replaces usage of std::stod by std::strtod.
It addresses #39627 independently raised also here #43100 (comment).

Backport of #43890

PR validation:

Identical to #43890 and validated for it.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #43890 to 14_0_X release series; it is needed for 2024 operations.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2024

A new Pull Request was created by @mbluj for CMSSW_14_0_X.

It involves the following packages:

  • RecoTauTag/RecoTau (reconstruction)

@jfernan2, @mandrenguyen, @cmsbuild can you please review it and eventually sign? Thanks.
@azotz, @mbluj, @missirol this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2024

cms-bot internal usage

@mandrenguyen
Copy link
Contributor

backport of #43890

@mandrenguyen
Copy link
Contributor

type tau

@mandrenguyen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c9c54a/37299/summary.html
COMMIT: c6d18fd
CMSSW: CMSSW_14_0_X_2024-02-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43909/37299/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 45 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3248626
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248601
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

backport of #43890

@mandrenguyen
Copy link
Contributor

+reconstruction

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9cf3267 into cms-sw:CMSSW_14_0_X Feb 12, 2024
21 checks passed
@mbluj mbluj deleted the CMSSW_14_0_X_tauWPthresholdExceptionFix branch March 13, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants