Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Update LHCInfoProducer to use LHCInfoCombined #43993

Merged

Conversation

francescobrivio
Copy link
Contributor

PR description:

Verbatim backport of #43956.

This PR updates the NanoAOD LHCInfoProducer module to be able to use both old LHCInfo (for Run 2) and new LHCInfoPer* records (for Run 3).

PR validation:

See master PR.

Backport:

Backport of #43956.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 16, 2024

A new Pull Request was created by @francescobrivio for CMSSW_14_0_X.

It involves the following packages:

  • CalibTracker/SiPixelQuality (alca)
  • DQM/CTPPS (dqm)
  • PhysicsTools/NanoAOD (xpog)

@tjavaid, @saumyaphor4252, @cmsbuild, @nothingface0, @antoniovagnerini, @syuvivida, @rvenditti, @hqucms, @perrotta, @vlimant, @consuegs can you please review it and eventually sign? Thanks.
@tocheng, @yuanchao, @mroguljic, @dkotlins, @AnnikaStein, @ferencek, @grzanka, @mmusich, @rsreds, @gpetruc, @fabferro, @tvami this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

backport of #43956

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 16, 2024

cms-bot internal usage

@francescobrivio
Copy link
Contributor Author

enable nano

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e215e0/37520/summary.html
COMMIT: 4698f3b
CMSSW: CMSSW_14_0_X_2024-02-15-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43993/37520/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16524
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16524
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 38 log files, 18 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.545 2.545 0.000 ( +0.0% ) 5.26 5.23 +0.4% 2.241 2.171
2500.001 2.692 2.692 0.000 ( +0.0% ) 4.70 4.69 +0.1% 2.679 2.582
2500.002 2.631 2.631 0.000 ( +0.0% ) 4.91 4.81 +2.0% 2.654 2.582
2500.01 1.315 1.315 0.000 ( +0.0% ) 9.72 9.38 +3.6% 2.357 2.253
2500.011 1.732 1.732 0.000 ( +0.0% ) 5.24 5.14 +2.0% 2.549 2.404
2500.012 1.578 1.578 0.000 ( +0.0% ) 7.61 7.29 +4.4% 2.460 2.371
2500.1 2.193 2.193 0.000 ( +0.0% ) 5.25 5.23 +0.3% 2.077 1.998
2500.2 2.307 2.307 0.000 ( +0.0% ) 6.07 5.99 +1.2% 1.991 1.898
2500.21 1.183 1.183 0.000 ( +0.0% ) 4.35 4.31 +0.8% 2.289 2.207
2500.211 1.547 1.547 0.000 ( +0.0% ) 3.73 3.73 +0.2% 2.372 2.236
2500.3 2.063 2.063 0.000 ( +0.0% ) 12.49 12.38 +0.9% 1.973 1.901
2500.31 1.259 1.259 0.000 ( +0.0% ) 19.47 19.13 +1.7% 2.373 2.251
2500.311 1.648 1.648 0.000 ( +0.0% ) 11.86 11.59 +2.3% 2.458 2.258
2500.312 7.159 7.159 0.000 ( +0.0% ) 1.38 1.36 +1.3% 1.698 1.699
2500.313 1.564 1.564 0.000 ( +0.0% ) 6.56 6.48 +1.3% 1.055 1.051
2500.4 2.063 2.063 0.000 ( +0.0% ) 12.48 12.40 +0.6% 1.979 1.902
2500.5 19.575 19.575 0.000 ( +0.0% ) 1.17 1.09 +7.8% 1.365 1.093

@vlimant
Copy link
Contributor

vlimant commented Feb 16, 2024

+1

@tjavaid
Copy link

tjavaid commented Feb 20, 2024

+1

@francescobrivio
Copy link
Contributor Author

+1

* spurious differences seen from unstable WF `12434.7` (open issue [spurious differences in outputs of wf `12434.7` (was `11634.7`) #39803](https://github.com/cms-sw/cmssw/issues/39803) )

Thanks @tjavaid ! Could you also sign the master PR?

@cms-sw/alca-l2 A kind ping to sign this backport (you already signed the master one).

@perrotta
Copy link
Contributor

@cms-sw/alca-l2 A kind ping to sign this backport (you already signed the master one).

Well, we normally wait for the master PR being merged and passing at least one IB before signing the backports. OTH the AlCa related part is quite trivial here, and I don't see why I should delay our signature also for the backport. Ok, let sign it since now.

@perrotta
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a9860ed into cms-sw:CMSSW_14_0_X Feb 26, 2024
12 checks passed
@francescobrivio francescobrivio deleted the alca-clean_old_LHCInfo_14_0_X branch May 5, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants