Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let tests fail gracefully if no devices are found [14.0.x] #44042

Merged
merged 18 commits into from
Feb 26, 2024
Merged

Let tests fail gracefully if no devices are found [14.0.x] #44042

merged 18 commits into from
Feb 26, 2024

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Feb 21, 2024 •
edited
Loading

PR description:

Let alpaka-based tests that require a device fail gracefully if there are no available devices on the given platform, instead of crashing or succeeding silently.

If more than one device is available, run the tests on each device.

PR validation:

Unit tests pass.

If there are no devices, the tests pass with an informational message instead of failing with a segmentation violation.

Backport status:

Backport of #44036, to make sure test failures do not go undetected in the production branch.

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 21, 2024

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 21, 2024

backport #44036

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Feb 21, 2024
@fwyzard fwyzard changed the base branch from master to CMSSW_14_0_X February 21, 2024 14:24
@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 21, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 21, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_0_X Feb 21, 2024
@fwyzard
Let the test fail gracefully if no devies are found
ef94b6d 
If more than one device is available, run the tests on all available
devices.
@fwyzard
Let the test fail gracefully if no devies are found
8ada384 
If more than one device is available, run the tests on all available
devices.

Replace elements_with_stide with uniform_elements.
@fwyzard
Let the test fail gracefully if no devies are found
79973a2 
If more than one device is available, run the tests on all available
devices.

Replace elements_with_stide with uniform_elements.
@fwyzard
Let the test fail gracefully if no devies are found
2d3d571 
If more than one device is available, run the tests on all available
devices.

Replace elements_with_stide with uniform_elements.
@fwyzard fwyzard force-pushed the make_tests_fail_gracefully_140x branch from 63af9c9 to 2d3d571 Compare February 21, 2024 21:29
@cmsbuild
Copy link
Contributor

Pull request #44042 was updated. @mandrenguyen, @makortel, @fwyzard, @jfernan2, @cmsbuild can you please check and sign again.

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 21, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3eb64/37614/summary.html
COMMIT: 2d3d571
CMSSW: CMSSW_14_0_X_2024-02-21-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44042/37614/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@jfernan2
Copy link
Contributor

+1

@makortel
Copy link
Contributor

+heterogeneous

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a234709 into cms-sw:CMSSW_14_0_X Feb 26, 2024
10 checks passed
@fwyzard fwyzard deleted the make_tests_fail_gracefully_140x branch March 2, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok bug-fix fully-signed heterogeneous-approved orp-approved reconstruction-approved tests-approved tracking trk
Projects
None yet
Milestone
CMSSW_14_0_X
Development

Successfully merging this pull request may close these issues.
5 participants
@fwyzard @cmsbuild @jfernan2 @makortel @rappoccio