[14_0_X] Update unpacker for L1T Calo scouting + DataFormat tests

[Mmiglio]

Backport of #44393 and Data Format tests of #43984

PR description:

This PR updates the unpacker for L1T Calo scouting, following the upgrade of HW/SW upgrade of the scouting DAQ system.
Backported also data format tests for files produced with previous releases.

PR validation:

The PR has been validated using data collected with the scouting system in the past week(s) and comparing results with L1T objects collected during CRAFT with the cdaq.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #44393 and #43984 to CMSSW_14_0_X for data tacking.

[cmsbuild]

A new Pull Request was created by @Mmiglio for CMSSW_14_0_X.

It involves the following packages:

• DataFormats/L1Scouting (daq)
• DataFormats/L1ScoutingRawData (daq)
• EventFilter/L1ScoutingRawToDigi (daq)
• L1TriggerScouting/Utilities (daq)

@cmsbuild, @smorovic, @emeschi can you please review it and eventually sign? Thanks.
@rovere, @missirol, @Martin-Grunewald this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[cmsbuild]

Pull request #44394 was updated. @smorovic, @cmsbuild, @emeschi can you please check and sign again.

[smorovic]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-66f749/38129/summary.html
COMMIT: f6b631a
CMSSW: CMSSW_14_0_X_2024-03-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44394/38129/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestL1ScoutingFormat had ERRORS

Comparison Summary

Summary:

• You potentially added 103 lines to the logs
• Reco comparison results: 62 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3346226
• DQMHistoTests: Total failures: 1356
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3344848
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 166 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[rappoccio]

hold

• We need a justification as to why this new feature is being backported to the stable branch. Only bug fixes should be backported.

[cmsbuild]

Pull request has been put on hold by @rappoccio
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[Mmiglio]

Hi @rappoccio,
We need this backport as the L1Scouting system hardware is changed, hence a slightly different unpacker is needed.
Moreover, as far as I understood, we need to be using the same CMSSW version as the HLT because of plans for common repacking.
On the other hand, touching the DataFormat tests is not really needed. I just thought it was a good Idea to align the changes, but of course I can restore the original version.

[cmsbuild]

Pull request #44394 was updated. @emeschi, @smorovic, @cmsbuild can you please check and sign again.

[Mmiglio]

Hi, I removed the unnecessary changes on the data format size. I kept only:

• A fix for OrbitCollection as the method getBxSize needs to return an unsigned
• Named tcp source IDs for the 2024 calo data source

Please let me know if there is anything more that can be done from side.

[smorovic]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-66f749/38223/summary.html
COMMIT: 26de14a
CMSSW: CMSSW_14_0_X_2024-03-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44394/38223/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 68 lines from the logs
• Reco comparison results: 53 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3346212
• DQMHistoTests: Total failures: 1352
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3344838
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 166 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[smorovic]

+daq

[aloeliger]

@dinyar, FYI. We were asked about this release and about any potential pitfalls. Were you aware of this change?

[dinyar]

Hi @aloeliger,

thanks for tagging me! Yes, this is the unpacker we'd like to use for data taking this year (along with some fixes). We're currently using a private version of CMSSW with these changes for our tests at P5, but we strongly prefer to use an actual release.

Cheers,
Dinyar

[antoniovilela]

unhold

[antoniovilela]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will be automatically merged.