-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [CPP20] Fix deprecated enum arithmetics #44469
Conversation
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44469/39553
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
b052128
to
fe4a9b1
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44469/39566
|
A new Pull Request was created by @iarspider for master. It involves the following packages:
@nothingface0, @mdhildreth, @saumyaphor4252, @tvami, @cmsbuild, @antoniovagnerini, @francescobrivio, @bsunanda, @Dr15Jones, @tjavaid, @consuegs, @perrotta, @rvenditti, @makortel, @civanch, @syuvivida can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
fe4a9b1
to
ff80e8e
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44469/39569
|
Pull request #44469 was updated. @consuegs, @subirsarkar, @bsunanda, @Dr15Jones, @srimanob, @nothingface0, @tjavaid, @francescobrivio, @civanch, @cmsbuild, @jfernan2, @mdhildreth, @aloeliger, @makortel, @perrotta, @mandrenguyen, @saumyaphor4252, @rvenditti, @syuvivida, @antoniovagnerini, @epalencia, @tvami can you please check and sign again. |
ff80e8e
to
098bc6c
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44469/39571
|
Pull request #44469 was updated. @civanch, @nothingface0, @jfernan2, @rvenditti, @syuvivida, @bsunanda, @tvami, @mdhildreth, @Dr15Jones, @francescobrivio, @cmsbuild, @epalencia, @makortel, @antoniovagnerini, @mandrenguyen, @tjavaid, @perrotta, @srimanob, @aloeliger, @consuegs, @saumyaphor4252, @subirsarkar can you please check and sign again. |
I think it's better to split it into several PRs. |
I think the alternative approach of converting enums to |
PR description:
In C++20, arithmetic and comparision operations between different
enum
s, and between floating-point types andenum
are deprecated:PR validation:
Bot tests