Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NanoAOD] Add number of B & C hadrons for GenJetAK8 and GenJet #44479

Merged

Conversation

nurfikri89
Copy link
Contributor

@nurfikri89 nurfikri89 commented Mar 20, 2024

PR description:

This PR adds the number of B/C-hadrons branches for GenJetAK8 and GenJet tables . The same branches are removed from the FatJet table. Addresses the Issue here.

PR validation:

passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 14_0_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 20, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44479/39567

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @nurfikri89 for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@hqucms, @vlimant, @cmsbuild can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@vlimant
Copy link
Contributor

vlimant commented Mar 20, 2024

enable nano

@vlimant
Copy link
Contributor

vlimant commented Mar 20, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e7bd8/38278/summary.html
COMMIT: 2aefc32
CMSSW: CMSSW_14_1_X_2024-03-19-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44479/38278/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 21 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 64 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297337
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3297311
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.936 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.121 KiB Physics/NanoAODDQM
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 14 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16374
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16374
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.694 KiB( 14 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): 0.121 KiB Physics/NanoAODDQM
  • Checked 47 log files, 27 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.553 2.548 0.005 ( +0.2% ) 5.31 5.10 +4.0% 2.242 2.232
2500.001 2.703 2.698 0.005 ( +0.2% ) 4.74 4.61 +2.8% 2.673 2.654
2500.002 2.643 2.638 0.005 ( +0.2% ) 4.93 4.81 +2.4% 2.667 2.667
2500.01 1.318 1.318 0.000 ( +0.0% ) 9.81 9.23 +6.4% 2.355 2.306
2500.011 1.740 1.740 0.000 ( +0.0% ) 5.30 5.17 +2.5% 2.549 2.542
2500.012 1.581 1.581 0.000 ( +0.0% ) 7.62 7.35 +3.7% 2.463 2.377
2500.1 2.196 2.192 0.005 ( +0.2% ) 5.26 5.12 +2.6% 2.067 2.063
2500.2 2.313 2.308 0.005 ( +0.2% ) 6.08 5.82 +4.5% 1.978 1.971
2500.21 1.181 1.181 0.000 ( +0.0% ) 4.31 4.22 +2.1% 2.275 2.265
2500.211 1.545 1.545 0.000 ( +0.0% ) 3.75 3.55 +5.9% 2.360 2.347
2500.3 2.062 2.058 0.005 ( +0.2% ) 12.68 11.41 +11.2% 1.961 1.962
2500.301 2.637 2.631 0.006 ( +0.2% ) 10.42 9.41 +10.8% 1.948 1.940
2500.31 1.254 1.254 0.000 ( +0.0% ) 19.78 18.53 +6.8% 2.359 2.337
2500.311 1.640 1.640 0.000 ( +0.0% ) 13.82 12.84 +7.6% 2.439 2.434
2500.312 7.159 7.159 0.000 ( +0.0% ) 1.44 1.36 +6.1% 1.701 1.705
2500.313 1.564 1.564 0.000 ( +0.0% ) 6.87 7.15 -3.9% 1.048 1.053
2500.314 1.163 1.163 0.000 ( +0.0% ) 14.56 13.53 +7.6% 2.207 2.121
2500.315 1.758 1.758 0.000 ( +0.0% ) 14.24 13.13 +8.4% 2.350 2.314
2500.316 3.091 3.091 0.000 ( +0.0% ) 2.26 2.09 +8.3% 2.273 2.278
2500.317 1.787 1.787 0.000 ( +0.0% ) 14.24 12.66 +12.5% 2.355 2.159
2500.4 2.062 2.058 0.005 ( +0.2% ) 12.66 11.68 +8.4% 1.964 1.877
2500.401 1.824 1.824 0.000 ( +0.0% ) 10.73 9.70 +10.6% 1.819 1.695
2500.402 2.637 2.631 0.006 ( +0.2% ) 10.25 9.40 +9.0% 1.952 1.947
2500.403 5.201 5.188 0.013 ( +0.2% ) 1.58 1.52 +3.7% 1.987 1.984
2500.404 2.626 2.620 0.006 ( +0.2% ) 10.16 9.06 +12.2% 1.948 1.758
2500.5 19.575 19.575 0.000 ( +0.0% ) 1.29 1.12 +15.1% 1.367 1.361

@vlimant
Copy link
Contributor

vlimant commented Mar 20, 2024

tagging @arizzi

@vlimant
Copy link
Contributor

vlimant commented Mar 27, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e01183f into cms-sw:master Mar 28, 2024
13 checks passed
cmsbuild added a commit that referenced this pull request Apr 2, 2024
…dronsInGenJets

[NanoAOD] Backport of #44479 (Add number of B & C hadrons for GenJetAK8 and GenJet) to 14_0_X
@nurfikri89 nurfikri89 deleted the from1410pre1_nano_nHadronsInGenJets branch July 6, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants