Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TkAl: protect unit tests against empty queries and drop unused tests #44588

Merged
merged 2 commits into from
Apr 3, 2024
Merged

TkAl: protect unit tests against empty queries and drop unused tests #44588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
711b567
add protections to test_unitSubmitPVrbr.sh and test_unitSubmitPVsplit…
mmusich Apr 2, 2024
fe9b0a5
drop unused test_all-in-one.sh, since when moved to the new all-in-on…
mmusich Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
163 changes: 0 additions & 163 deletions Alignment/OfflineValidation/test/testingScripts/test_all-in-one.sh
View file
Open in desktop

This file was deleted.

11 changes: 9 additions & 2 deletions Alignment/OfflineValidation/test/testingScripts/test_unitSubmitPVrbr.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,15 @@ scriptName="PVValidation_testingOfflineGT_HLTPhysics_Run2023D_0.sh"
# Create directory if it doesn't exist
mkdir -p "./testExecution"

# Copy script to the test execution directory
cp -pr "./BASH/${scriptName}" "./testExecution/"
# Check if the script exists and is a regular file
if [ -f "./BASH/${scriptName}" ]; then
# Copy script to the test execution directory
cp -pr "./BASH/${scriptName}" "./testExecution/"
else
# Emit a warning if the script doesn't exist or is not a regular file
echo "Warning: Script '${scriptName}' not found or is not a regular file. Skipping excution of further tests."
exit 0
fi

# Change directory to the test execution directory
cd "./testExecution" || exit 1
Expand Down
11 changes: 9 additions & 2 deletions Alignment/OfflineValidation/test/testingScripts/test_unitSubmitPVsplit.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,15 @@ scriptName="batchHarvester_Prompt_0.sh"
# Create directory if it doesn't exist
mkdir -p "./testExecution"

# Copy script to the test execution directory
cp -pr "./BASH/${scriptName}" "./testExecution/"
# Check if the script exists and is a regular file
if [ -f "./BASH/${scriptName}" ]; then
# Copy script to the test execution directory
cp -pr "./BASH/${scriptName}" "./testExecution/"
else
# Emit a warning if the script doesn't exist or is not a regular file
echo "Warning: Script '${scriptName}' not found or is not a regular file. Skipping excution of further tests."
exit 0
fi

# Change directory to the test execution directory
cd "./testExecution" || exit 1
Expand Down