Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of the LumiPCC module veto list and afterglow factors for 2024 [CMSSW_14_0_X] #44629

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

radla118
Copy link
Contributor

@radla118 radla118 commented Apr 5, 2024

PR description:

Update of the LumiPCC module veto list and afterglow parameters implemented in the corresponding configuration files. Backport of PR #44568

PR validation:

Validated by running runTheMatrix.py -l 1020.0 configuration.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

The modified parameters are intended to be used for the 2024 data-taking period (CMSSW_14_0_2).

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2024

A new Pull Request was created by @radla118 for CMSSW_14_0_X.

It involves the following packages:

  • Calibration/LumiAlCaRecoProducers (alca)

@perrotta, @saumyaphor4252, @cmsbuild, @consuegs can you please review it and eventually sign? Thanks.
@mmusich, @rsreds, @tocheng, @yuanchao this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2024

cms-bot internal usage

@perrotta
Copy link
Contributor

perrotta commented Apr 5, 2024

please test

@perrotta
Copy link
Contributor

perrotta commented Apr 5, 2024

backport of #44568

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56a395/38620/summary.html
COMMIT: 9196f92
CMSSW: CMSSW_14_0_X_2024-04-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44629/38620/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 46 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3346180
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3346155
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Apr 5, 2024

+alca

  • (Copying here the same comments written while approving the master version of this PR)
  • Same procedure to determine the misbehaving modules with past year data as was done for similar previous PRs
  • The migration towards the storage of these parameters in the db rather than in python config is still ongoing...

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f2064cf into cms-sw:CMSSW_14_0_X Apr 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants