Phase2L1CaloJetEmulator: fix maybe-uninitialized warning #44633

iarspider · 2024-04-05T13:00:23Z

PR description:

GCC emits the following maybe-uninitialized warnings:

  ...src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h:387:11: warning: 'eta_slice[1]' may be used uninitialized [-Wmaybe-uninitialized]
   387 |     float eta_slice[3];
      |           ^
In function 'getJetValues',
    inlined from 'getRegion' at ...src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h:450:23,
    inlined from 'produce' at src/L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloJetEmulator.cc:475:33:
  ...src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h:421:35: warning: 'eta_slice[0]' may be used uninitialized [-Wmaybe-uninitialized]
   421 |     jet_tmp.energy = eta_slice[0] + eta_slice[1] + eta_slice[2];
      |                                   ^
...src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h: In member function 'produce':
...src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h:387:11: note: 'eta_slice[0]' was declared here
  387 |     float eta_slice[3];
      |           ^
In function 'getJetValues',
    inlined from 'getRegion' at ...src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h:450:23,
    inlined from 'produce' at src/L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloJetEmulator.cc:430:33:
  ...src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h:421:50: warning: 'eta_slice[2]' may be used uninitialized [-Wmaybe-uninitialized]
   421 |     jet_tmp.energy = eta_slice[0] + eta_slice[1] + eta_slice[2];
      |                                                  ^
...src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h: In member function 'produce':
...src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h:387:11: note: 'eta_slice[2]' was declared here
  387 |     float eta_slice[3];
      |           ^
  ...src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h:387:11: warning: 'eta_slice[1]' may be used uninitialized [-Wmaybe-uninitialized]
 In function 'getJetValues',
    inlined from 'getRegion' at ...src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h:450:23,
    inlined from 'produce' at src/L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloJetEmulator.cc:520:33:
  ...src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h:421:50: warning: 'eta_slice[2]' may be used uninitialized [-Wmaybe-uninitialized]
   421 |     jet_tmp.energy = eta_slice[0] + eta_slice[1] + eta_slice[2];
      |                                                  ^
...src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h: In member function 'produce':
...src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h:387:11: note: 'eta_slice[2]' was declared here
  387 |     float eta_slice[3];
      |           ^
  ...src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h:387:11: warning: 'eta_slice[1]' may be used uninitialized [-Wmaybe-uninitialized]
 In function 'getJetValues',
    inlined from 'getRegion' at ...src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h:450:23,
    inlined from 'produce' at src/L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloJetEmulator.cc:430:33:
  ...src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h:421:35: warning: 'eta_slice[0]' may be used uninitialized [-Wmaybe-uninitialized]
   421 |     jet_tmp.energy = eta_slice[0] + eta_slice[1] + eta_slice[2];
      |                                   ^
...src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h: In member function 'produce':
...src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h:387:11: note: 'eta_slice[0]' was declared here
  387 |     float eta_slice[3];
      |           ^
In function 'getJetValues',
    inlined from 'getRegion' at ...src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h:450:23,
    inlined from 'produce' at src/L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloJetEmulator.cc:520:33:
  ...src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h:421:35: warning: 'eta_slice[0]' may be used uninitialized [-Wmaybe-uninitialized]
   421 |     jet_tmp.energy = eta_slice[0] + eta_slice[1] + eta_slice[2];
      |                                   ^
...src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h: In member function 'produce':
...src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h:387:11: note: 'eta_slice[0]' was declared here
  387 |     float eta_slice[3];
      |           ^
In function 'getJetValues',
    inlined from 'getRegion' at ...src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h:450:23,
    inlined from 'produce' at src/L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloJetEmulator.cc:475:33:
  ...src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h:421:50: warning: 'eta_slice[2]' may be used uninitialized [-Wmaybe-uninitialized]
   421 |     jet_tmp.energy = eta_slice[0] + eta_slice[1] + eta_slice[2];
      |                                                  ^
...src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h: In member function 'produce':
...src/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h:387:11: note: 'eta_slice[2]' was declared here
  387 |     float eta_slice[3];
      |           ^

log

PR validation:

Bot tests

iarspider · 2024-04-05T13:00:37Z

please test for CMSSW_14_1_DBG_X

cmsbuild · 2024-04-05T13:00:45Z

cms-bot internal usage

cmsbuild · 2024-04-05T13:06:18Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44633/39822

This PR adds an extra 16KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/L1CaloTrigger/interface/Phase2L1CaloJetEmulator.h modified in PR(s): [Phase-2 L1T] Updated of GCT jets and taus collection #44606

cmsbuild · 2024-04-05T13:06:44Z

A new Pull Request was created by @iarspider for master.

It involves the following packages:

L1Trigger/L1CaloTrigger (upgrade, l1)

@epalencia, @srimanob, @aloeliger, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2024-04-06T00:39:30Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19cb75/38630/summary.html
COMMIT: 11e7a49
CMSSW: CMSSW_14_1_DBG_X_2024-04-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44633/38630/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@brunolopesbr2 Add QuadJet with 3 b-tag PNet trigger to the DQM offline #44546

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19cb75/38630/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19cb75/38630/git-merge-result

Comparison Summary

Summary:

You potentially added 3927610 lines to the logs
Reco comparison results: 45651 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3307717
DQMHistoTests: Total failures: 93053
DQMHistoTests: Total nulls: 82
DQMHistoTests: Total successes: 3214562
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 4.397 KiB( 47 files compared)
DQMHistoSizes: changed ( 13034.0 ): 3.433 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 141.042 ): 0.004 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 250202.181 ): 0.182 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): 0.778 KiB SiStrip/MechanicalView
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: found differences in 11 / 46 workflows

aloeliger · 2024-04-08T08:50:09Z

+l1

technical change

srimanob · 2024-04-08T12:53:00Z

@cmsbuild please test

To make the clean test, as so many failures in various workflows.

cmsbuild · 2024-04-08T17:44:19Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19cb75/38681/summary.html
COMMIT: 11e7a49
CMSSW: CMSSW_14_1_X_2024-04-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44633/38681/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 78 lines from the logs
Reco comparison results: 43 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3307717
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3307697
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

srimanob · 2024-04-10T17:05:20Z

+Upgrade

cmsbuild · 2024-04-10T17:05:42Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2024-04-11T17:31:45Z

+1

Phase2L1CaloJetEmulator: fix maybe-uninitialized warning

11e7a49

cmsbuild added this to the CMSSW_14_1_X milestone Apr 5, 2024

cmsbuild added l1-pending pending-signatures orp-pending tests-started upgrade-pending code-checks-pending labels Apr 5, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 5, 2024

cmsbuild added tests-approved and removed tests-started labels Apr 6, 2024

cmsbuild added l1-approved and removed l1-pending labels Apr 8, 2024

cmsbuild mentioned this pull request Apr 8, 2024

[Phase-2 L1T] Updated of GCT jets and taus collection #44606

Merged

cmsbuild added tests-started and removed tests-approved labels Apr 8, 2024

cmsbuild added tests-approved and removed tests-started labels Apr 8, 2024

cmsbuild removed pending-signatures upgrade-pending labels Apr 10, 2024

cmsbuild added fully-signed upgrade-approved labels Apr 10, 2024

cmsbuild added orp-approved and removed orp-pending labels Apr 11, 2024

cmsbuild merged commit 4e84435 into cms-sw:master Apr 11, 2024
17 checks passed

This was referenced Apr 11, 2024

Explicit lazy parsing in SimpleFlatTableProducer #44575

Closed

updated parameters and model for photon XGboost MVA (HLT) [14_1_X] #44719

Merged

iarspider deleted the patch-6 branch April 12, 2024 08:08

This was referenced Apr 12, 2024

Introduce Unified Particle Transformer AK4 jet tagger #44641

Merged

Rivet 4.0.0 and YODA 2.0.0 cms-sw/cmsdist#9111

Merged

Pythia 8.311 cms-sw/cmsdist#8938

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase2L1CaloJetEmulator: fix maybe-uninitialized warning #44633

Phase2L1CaloJetEmulator: fix maybe-uninitialized warning #44633

iarspider commented Apr 5, 2024

iarspider commented Apr 5, 2024

cmsbuild commented Apr 5, 2024 •

edited

Loading

cmsbuild commented Apr 5, 2024

cmsbuild commented Apr 5, 2024

cmsbuild commented Apr 6, 2024

aloeliger commented Apr 8, 2024

srimanob commented Apr 8, 2024

cmsbuild commented Apr 8, 2024

srimanob commented Apr 10, 2024

cmsbuild commented Apr 10, 2024

antoniovilela commented Apr 11, 2024

Phase2L1CaloJetEmulator: fix maybe-uninitialized warning #44633

Phase2L1CaloJetEmulator: fix maybe-uninitialized warning #44633

Conversation

iarspider commented Apr 5, 2024

PR description:

PR validation:

iarspider commented Apr 5, 2024

cmsbuild commented Apr 5, 2024 • edited Loading

cmsbuild commented Apr 5, 2024

cmsbuild commented Apr 5, 2024

cmsbuild commented Apr 6, 2024

Comparison Summary

aloeliger commented Apr 8, 2024

srimanob commented Apr 8, 2024

cmsbuild commented Apr 8, 2024

Comparison Summary

srimanob commented Apr 10, 2024

cmsbuild commented Apr 10, 2024

antoniovilela commented Apr 11, 2024

cmsbuild commented Apr 5, 2024 •

edited

Loading