Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ParticleNetLegacy when running Nano on Run2UL samples #44726

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

hqucms
Copy link
Contributor

@hqucms hqucms commented Apr 12, 2024

PR description:

This PR fixes the running of the legacy AK8 ParticleNet mass regression in the Nano step on Run2 UL MiniAODs, which was accidentally removed in #44507.

PR validation:

Tested with nano matrix.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 12, 2024

cms-bot internal usage

@hqucms hqucms changed the title Fix ParticleNetLegacy on Run2 samples. Fix ParticleNetLegacy when running Nano on Run2UL samples Apr 12, 2024
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44726/39936

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hqucms for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@vlimant, @cmsbuild, @hqucms can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@hqucms
Copy link
Contributor Author

hqucms commented Apr 12, 2024

enable nano

@hqucms
Copy link
Contributor Author

hqucms commented Apr 12, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d8e1b/38821/summary.html
COMMIT: 6ed43a9
CMSSW: CMSSW_14_1_X_2024-04-12-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44726/38821/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 63 lines to the logs
  • Reco comparison results: 38 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3316263
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3316243
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16484
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16478
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 55 log files, 32 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.575 2.574 0.000 ( +0.0% ) 4.57 4.60 -0.6% 2.183 2.234
2500.001 2.722 2.721 0.001 ( +0.0% ) 4.04 4.09 -1.2% 2.573 2.655
2500.002 2.667 2.667 0.000 ( +0.0% ) 4.24 4.24 -0.0% 2.559 2.653
2500.01 1.320 1.320 0.000 ( +0.0% ) 8.22 8.34 -1.4% 2.310 2.353
2500.011 1.742 1.741 0.001 ( +0.1% ) 4.58 4.63 -1.1% 2.446 2.539
2500.012 1.583 1.583 0.000 ( +0.0% ) 6.44 6.58 -2.1% 2.369 2.445
2500.1 2.259 2.259 0.000 ( +0.0% ) 4.57 4.54 +0.6% 2.074 2.071
2500.2 2.366 2.366 0.000 ( +0.0% ) 5.15 5.18 -0.7% 1.987 1.981
2500.21 1.200 1.200 0.000 ( +0.0% ) 3.54 3.51 +0.9% 2.265 2.266
2500.211 1.568 1.568 0.000 ( +0.0% ) 3.19 3.13 +1.7% 2.346 2.342
2500.3 2.139 2.139 0.000 ( +0.0% ) 9.74 9.79 -0.5% 1.977 1.965
2500.301 2.730 2.730 0.000 ( +0.0% ) 8.49 7.95 +6.8% 1.963 1.958
2500.31 7.164 7.164 0.000 ( +0.0% ) 1.23 1.35 -8.5% 1.706 1.707
2500.311 1.568 1.568 0.000 ( +0.0% ) 6.92 6.53 +5.9% 1.055 1.061
2500.312 540.457 540.457 0.000 ( +0.0% ) 0.53 0.52 +2.9% 1.631 1.586
2500.313 817.694 817.694 0.000 ( +0.0% ) 0.72 0.71 +1.6% 1.595 1.577
2500.32 1.283 1.283 0.000 ( +0.0% ) 12.73 13.01 -2.1% 2.329 2.367
2500.321 1.675 1.675 0.000 ( +0.0% ) 9.80 9.72 +0.8% 2.442 2.441
2500.322 1.195 1.195 0.000 ( +0.0% ) 10.36 10.14 +2.3% 2.111 2.135
2500.323 7.772 7.772 0.000 ( +0.0% ) 3.21 3.39 -5.4% 1.821 1.933
2500.324 1.791 1.791 0.000 ( +0.0% ) 9.99 9.89 +1.0% 2.201 2.205
2500.325 4.176 4.176 0.000 ( +0.0% ) 4.20 4.05 +3.6% 2.218 2.224
2500.326 3.127 3.127 0.000 ( +0.0% ) 1.77 1.81 -2.1% 2.094 2.219
2500.327 1.822 1.822 0.000 ( +0.0% ) 9.87 9.91 -0.4% 2.330 2.348
2500.4 2.308 2.308 0.000 ( +0.0% ) 9.37 9.37 -0.1% 1.845 1.833
2500.401 1.855 1.855 0.000 ( +0.0% ) 8.14 7.89 +3.1% 1.732 1.708
2500.402 2.874 2.874 0.000 ( +0.0% ) 7.89 8.04 -1.9% 1.907 1.916
2500.403 8.830 8.830 0.000 ( +0.0% ) 2.73 2.72 +0.3% 1.954 1.887
2500.404 5.183 5.183 0.000 ( +0.0% ) 1.31 1.32 -0.8% 1.791 1.782
2500.405 2.881 2.881 0.000 ( +0.0% ) 8.04 8.01 +0.3% 1.916 1.915
2500.5 5.194 5.194 0.000 ( +0.0% ) 15.89 15.88 +0.1% 1.578 1.574
2500.51 9.120 9.120 0.000 ( +0.0% ) 9.57 9.59 -0.2% 1.522 1.520

@hqucms
Copy link
Contributor Author

hqucms commented Apr 12, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 40583c2 into cms-sw:master Apr 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants