Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport of LHEmttFilter for 10_6 #44745

Merged
merged 1 commit into from
May 1, 2024

Conversation

agrohsje
Copy link

PR description/backport info:

This PR is a backport of the LHE mttbar filter to 10_6. It is needed for UL EFT MC samples.

PR validation:

I verified that the code works properly in 10_6. Generating a few events and plotting mttbar all looked good.

This is a link to the original PR by Giulia:
#33541

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @agrohsje for CMSSW_10_6_X.

It involves the following packages:

  • GeneratorInterface/GenFilters (generators)

@GurpreetSinghChahal, @SiewYan, @menglu21, @cmsbuild, @bbilin, @alberto-sanchez, @mkirsano can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 15, 2024

cms-bot internal usage

@agrohsje
Copy link
Author

can someone issue please test ? @menglu21 @bbilin ? thanks!

@agrohsje
Copy link
Author

ping @menglu21 @bbilin .

@bbilin
Copy link
Contributor

bbilin commented Apr 23, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-741983/39031/summary.html
COMMIT: f12eaf2
CMSSW: CMSSW_10_6_X_2024-04-22-2300/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44745/39031/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215351
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 144 log files, 103 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@agrohsje
Copy link
Author

Hi @rappoccio . Is there already the new 10_6 release? Could still go in? @menglu21 @bbilin please sign the back-port. Thanks!

@bbilin
Copy link
Contributor

bbilin commented Apr 25, 2024

+1

Sorry to have missed it for 10_6_41...

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4aa5b52 into cms-sw:CMSSW_10_6_X May 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants