Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ordering of egamma HLT modules in unseeded paths #44849

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

swagata87
Copy link
Contributor

PR description:

This is part II of #44592

In realistic phase2 menu, we only have L1 seeded egamma paths. So that was fixed (in #44592) as soon as the issue was spotted. However, the unseeded paths are also part of CMSSW so it's a good idea to not leave them with known issues. So, the unseeded paths' ordering is being fixed in this PR.

In Run2/Run3 it was common to use a mix of seeded and unseeded paths/legs. Specially, for multi-EG paths, it is rather common to use one seeded leg and keep others unseeded. Unseeded reco has higher efficiency, but also higher resource/timing cost. Depending on how CPU/GPU timing evolves for phase2 menu over next months/years, the same strategy (ie use both seeded and unseeded as necessary) can be done in phase2 HLT. So, the unseeded paths might become part of realistic menu some day, although now they are not.

PR validation:

Phase 2 HLT menu runs.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 25, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44849/40100

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @swagata87 for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks.
@missirol, @SohamBhattacharya, @rovere, @silviodonato, @Martin-Grunewald this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor

please test

@swagata87
Copy link
Contributor Author

type egamma

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5847d1/39101/summary.html
COMMIT: 1544a00
CMSSW: CMSSW_14_1_X_2024-04-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44849/39101/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
546.0 step 2
547.0 step 3
548.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8925bfa into cms-sw:master Apr 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants