[14.0.X] Computation of silicon strip hit efficiency : Consecutive missing hits recovery

[mmusich]

backport of #45008
backport of #44858

PR description:

This PR is a combined backport.
The goal is s apply in the 2024 data-taking release the correction introduced in PR #44858 to both the SiStripHitEfficiencyWorker module which is run as part of the PromptCalibProdSiStripHitEff Prompt Calibration Loop workflow and the standalone HitEff class used in the SiStrip Calibration trees.
Features introduced (as per #44858 (comment)):

• Improvement of the missing hits recovery within the strips, to take into account two consecutive missing hits when one is located in an inactive modules;
• Expected output is a slight change in the hit efficiency per layer, as shown in the slides presented during the Strip calibration and local reconstruction meeting here ( Recovery of consecutive missing hits )

PR validation:

See #45008 (comment)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim combined backport of #45008 and #44858

[mmusich]

type bug-fix

[cmsbuild]

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

• CalibTracker/SiStripHitEfficiency (alca)

@perrotta, @cmsbuild, @consuegs, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@gbenelli, @robervalwalsh, @yuanchao, @tocheng, @mmusich, @rsreds, @echabert this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from SiStripHitEfficiencyWorker: adding consecutive missing hits recovery when one of the two hits is in an inactive module #45008

[cmsbuild]

cms-bot internal usage

[mmusich]

test parameters:

• workflows = 1001, 1001.2, 1001.3, 1001.4, 1002.3

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c35a3e/39462/summary.html
COMMIT: 6ecb94d
CMSSW: CMSSW_14_0_X_2024-05-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45014/39462/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 100 lines from the logs
• Reco comparison results: 42 differences found in the comparisons
• DQMHistoTests: Total files compared: 52
• DQMHistoTests: Total histograms compared: 3363945
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3363922
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
• Checked 223 log files, 169 edm output root files, 52 DQM output files
• TriggerResults: no differences found

[perrotta]

+alca

• Verbatim combined backport of SiStripHitEfficiencyWorker: adding consecutive missing hits recovery when one of the two hits is in an inactive module #45008 and Computation of silicon strip hit efficiency : Consecutive missing hits recovery #44858, both already merged in master

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1