Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled ROCs for Online DQM Pixel Summary (BP) #45027

Merged

Conversation

alaperto
Copy link
Contributor

@alaperto alaperto commented May 23, 2024

Exclude disabled ROCs when calculating the fraction of "good" ROCs for the Online DQM Pixel Summary map.

PR validation:

Data produced with cmsRun on recent 2024 pp run 380400:

cmsRun DQM/Integration/python/clients/pixel_dqm_sourceclient-live_cfg.py dataset=/ZeroBias/Run2024D-v1/RAW runNumber=380400

Results available in private GUI

About backport

This is a backport to 14_0_X of #45026

@cmsbuild
Copy link
Contributor

cmsbuild commented May 23, 2024

A new Pull Request was created by @alaperto for CMSSW_14_0_X.

It involves the following packages:

  • DQM/SiPixelPhase1Summary (dqm)

@antoniovagnerini, @nothingface0, @cmsbuild, @tjavaid, @rvenditti, @syuvivida can you please review it and eventually sign? Thanks.
@idebruyn, @fioriNTU, @jandrea, @sroychow, @threus, @mmusich, @arossi83 this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 23, 2024

cms-bot internal usage

@sroychow
Copy link
Contributor

backport of #45026

@sroychow
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fedb6d/39493/summary.html
COMMIT: 0f3e711
CMSSW: CMSSW_14_0_X_2024-05-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45027/39493/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@sroychow
Copy link
Contributor

urgent

@gabrielmscampos
Copy link

PR tested and is working properly in DQM playback machines.

@tjavaid
Copy link

tjavaid commented May 24, 2024

+1

PR tested and is working properly in DQM playback machines.

thanks! @gabrielmscampos .

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 906595f into cms-sw:CMSSW_14_0_X May 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants