guard against invalid output products from HLTL1TSeed [14_0_X]

[missirol]

backport of #45047

PR description:

From the description of #45047.

This PR adds a safeguard to ensure that the plugin HLTL1TSeed does not add to the Event invalid references to L1T objects (by means of incorrect indices). For more information, see #44940 and CMSHLT-3216.

PR validation:

See #45047.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#45047

Backport of a fix relevant to HLT for 2024 data-taking (avoids a recurring HLT crash).

[cmsbuild]

A new Pull Request was created by @missirol for CMSSW_14_0_X.

It involves the following packages:

• HLTrigger/HLTfilters (hlt)

@mmusich, @cmsbuild, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@silviodonato, @Martin-Grunewald this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from guard against invalid output products from HLTL1TSeed #45047

[cmsbuild]

cms-bot internal usage

[mmusich]

@cmsbuild, please test

[francescobrivio]

urgent

• needed for an HLT patch release

[francescobrivio]

type hlt-integration

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-539b2c/39531/summary.html
COMMIT: ebc1169
CMSSW: CMSSW_14_0_X_2024-05-26-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45048/39531/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 40 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3333953
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3333933
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[francescobrivio]

@cms-sw/hlt-l2 please consider signing this so we can include it in the special patch.

Thanks!
Francesco as ORM

[mmusich]

please consider signing this so we can include it in the special patch.

are we not waiting to see IB results anymore?

[francescobrivio]

please consider signing this so we can include it in the special patch.

are we not waiting to see IB results anymore?

I thought (maybe erroneously) that was the Release Managers' job to wait for the IB before merging.
In any case the 14_1_X IB is now running with the master PR included, so we will hopefully see the results soon!

[mmusich]

+hlt

• looks like CMSSW_14_1 2024-05-27-1100 (including the master PR guard against invalid output products from HLTL1TSeed #45047) has no major issues (the HLT IB tests are not yet ready, though).

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1