Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[140X] Protection for invalid TSOS in MuonTrajectoryUpdator #45061

Merged
merged 1 commit into from
May 29, 2024

Conversation

24LopezR
Copy link
Contributor

PR description:

This PR addresses #45035
Attempts to fix a crash observed when KFUpdator returns an invalid trajectory state on surface.
Whenever this happens, muon trajectory updator skips that recHit.

PR validation:

Code compiles and has been tested in affected jobs

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a plain backport of #45053

@cmsbuild
Copy link
Contributor

cmsbuild commented May 27, 2024

A new Pull Request was created by @24LopezR for CMSSW_14_0_X.

It involves the following packages:

  • RecoMuon/TrackingTools (reconstruction)

@mandrenguyen, @cmsbuild, @jfernan2 can you please review it and eventually sign? Thanks.
@JanFSchulte, @rociovilar, @HuguesBrun, @Fedespring, @missirol, @abbiendi, @andrea21z, @jhgoh, @trocino, @bellan, @CeliaFernandez, @cericeci this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 27, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor

mmusich commented May 27, 2024

backport of #45053

@mmusich
Copy link
Contributor

mmusich commented May 27, 2024

type muon

@mmusich
Copy link
Contributor

mmusich commented May 27, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a9e659/39555/summary.html
COMMIT: 986aab3
CMSSW: CMSSW_14_0_X_2024-05-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45061/39555/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a31a769 into cms-sw:CMSSW_14_0_X May 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants