Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Monopole SKIM updates for Run 3 #45128

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

ThOliveira23
Copy link
Contributor

@ThOliveira23 ThOliveira23 commented Jun 4, 2024

PR description:

Provide an update to the trigger paths to be employed in the MONOPOLE SKIM file for the Run 3. The additional inclusion of trigger paths associated with MET can be mentioned.
Additionally, the inclusion of the EXOMONOPOLE SKIM file to be executed in the MET and JetMET datasets for the Run 3.

PR validation:
The PR was validated through the the basic test procedure available in the CMSSW PR instructions

This PR is a backport of #45134 for the release 14_0_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2024

A new Pull Request was created by @ThOliveira23 for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@miquork, @AdrianoDee, @sunilUIET, @cmsbuild can you please review it and eventually sign? Thanks.
@youyingli, @missirol, @Martin-Grunewald, @fabiocos this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2024

cms-bot internal usage

@ThOliveira23
Copy link
Contributor Author

FYI: @malbouis, @srimanob, @CarstenHensel

@AdrianoDee
Copy link
Contributor

@ThOliveira23 which is the runTheMatrix wf using this skim (if any)?

@srimanob
Copy link
Contributor

srimanob commented Jun 4, 2024

Should PR go to master first?

@ThOliveira23
Copy link
Contributor Author

@ThOliveira23 which is the runTheMatrix wf using this skim (if any)?

Dear @AdrianoDee, I'm not sure if I understood the question.

@malbouis
Copy link
Contributor

malbouis commented Jun 4, 2024

@ThOliveira23 which is the runTheMatrix wf using this skim (if any)?

Hi @AdrianoDee , for the DATA workflows, I think any workflow running the SKIM:EGamma* or SKIM:JetMET* datasets will run it due to the autoSkim matrix.

@AdrianoDee
Copy link
Contributor

AdrianoDee commented Jun 4, 2024

Dear @AdrianoDee, I'm not sure if I understood the question.

Yes sorry I was a bit obscure, I was "jargony" referring to the workflows we could use to test this setup in the release Helena kindly pointed to them. Anyway as @srimanob was mentioning, would be better if you can open the corresponding PR to master. And also make it clear in the title this PR is to 14_0_X (you can simply prepend [14_0_X] to it as in, e.g., #45115).

@youyingli
Copy link
Contributor

Hi @ThOliveira23 , just make sure if the update is for full Run3 or just 2024. And from your skim config, you mention that the updating aims at 2024, but there is no MET dataset in 2024 as it's merged into JetMET.

On the other hand, I also roughly check your HLT Paths but it seems that HLT_PFMET170_HBHECleaned_v*, HLT_PFMET300_v* are only for 2016 data taking and HLT_PFMET250_HBHECleaned_v* and HLT_PFMET200_HBHE_BeamHaloCleaned_v* are only for 2017 and 2018 data taking. Could you please check if the paths are what you expect in 2024 (or full Run3 I could say)?

@ThOliveira23
Copy link
Contributor Author

Hi @ThOliveira23 , just make sure if the update is for full Run3 or just 2024. And from your skim config, you mention that the updating aims at 2024, but there is no MET dataset in 2024 as it's merged into JetMET.

On the other hand, I also roughly check your HLT Paths but it seems that HLT_PFMET170_HBHECleaned_v*, HLT_PFMET300_v* are only for 2016 data taking and HLT_PFMET250_HBHECleaned_v* and HLT_PFMET200_HBHE_BeamHaloCleaned_v* are only for 2017 and 2018 data taking. Could you please check if the paths are what you expect in 2024 (or full Run3 I could say)?

Dear @youyingli, these updates are meant to cover all the Run 3, not only 2024. If I understood and implemented correctly, there is MET and JetMET for 2022 and only JetMET for 2023 (and 2024). In that sense, the idea is execute the Monopole SKIM in all the MET datasets of the Run 3.

Concerning the trigger paths: The expected trigger paths for the Run 3 HLT_PFMET200_BeamHaloCleaned_v* and the HLT_Photon200_v*. If the trigger paths concerning the Run 2 (2016 and 2017, 2018) aren't necessary, I think that they can be removed from the skim config file.

@ThOliveira23 ThOliveira23 changed the title Monopole SKIM updates for Run 3 [14_0_X] Monopole SKIM updates for Run 3 Jun 7, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2024

Pull request #45128 was updated. @AdrianoDee, @miquork, @sunilUIET, @cmsbuild can you please check and sign again.

@srimanob
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bcbfb5/39992/summary.html
COMMIT: b4ed0c6
CMSSW: CMSSW_14_0_X_2024-06-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45128/39992/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 84 lines to the logs
  • Reco comparison results: 56 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3342458
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3342432
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@youyingli
Copy link
Contributor

Hi @cms-sw/pdmv-l2, could you please sign this PR?

@sunilUIET
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

Please add a link to the master PR in the description, and indicate this is a backport.

@ThOliveira23
Copy link
Contributor Author

The PR description was updated. The backport indication and the link of the PR for the master were added.

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a0f8f37 into cms-sw:CMSSW_14_0_X Jul 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants