Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Herwig LHE matching fix and Matchbox relval for 13_0 #45241

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

Dominic-Stafford
Copy link
Contributor

Backports #42673 and #42732 (which add a new Herwig7HadronizerFilter, designed to resolve the issue of the wrong lhe events being saved with Herwig) and #43261 (which adds a new workflow 539 for testing the Matchbox mode of Herwig) for use in 2023 gen production.

Should be tested with cms-sw/cmsdist#9247 - the Herwig relvals to run are 535, 537, 538 and 539.

…g events

Read lhe event numbers in, if present

Add HadroniserFilter to Herwig which correctly matches LHE numbers between CMSSW and herwig

Add option to Herwig input fragements to use LHE numbering

Change test examples to use new HadroniserFilter+ LHE numbering

code style

code style

Call addLHEnumbers from mergeLHE.py if asked to number events and not using the DefaultLHEMerger

Number events before merge (so numbers are also available to LHEReader)

Include evtnum in LHEEventProduct (necesary for multithreading)
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dominic-Stafford for CMSSW_13_0_X.

It involves the following packages:

  • Configuration/Generator (generators)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • GeneratorInterface/Herwig7Interface (generators)
  • GeneratorInterface/LHEInterface (generators)
  • SimDataFormats/GeneratorProducts (generators)

@sunilUIET, @menglu21, @subirsarkar, @srimanob, @AdrianoDee, @GurpreetSinghChahal, @SiewYan, @alberto-sanchez, @kskovpen, @mkirsano, @bbilin, @cmsbuild, @miquork can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @makortel, @youyingli, @alberto-sanchez, @mkirsano, @apsallid, @fabiocos, @rovere, @slomeo, @bsunanda, @missirol, @mmusich this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 17, 2024

cms-bot internal usage

@menglu21
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f4eca4/39956/summary.html
COMMIT: b64e06c
CMSSW: CMSSW_13_0_X_2024-06-16-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45241/39956/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@menglu21
Copy link
Contributor

+1

@srimanob
Copy link
Contributor

+Upgrade

@AdrianoDee
Copy link
Contributor

please test
(just refreshing)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f4eca4/40290/summary.html
COMMIT: b64e06c
CMSSW: CMSSW_13_0_X_2024-07-07-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45241/40290/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit feb3276 into cms-sw:CMSSW_13_0_X Jul 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants