-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CachingAllocator debug for non-async operations [14.0.x] #45374
Fix CachingAllocator debug for non-async operations [14.0.x] #45374
Conversation
type bugfix |
backport #45368 |
enable gpu |
please test |
A new Pull Request was created by @fwyzard for CMSSW_14_0_X. It involves the following packages:
@fwyzard, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
cms-bot internal usage |
Pull request #45374 was updated. @AdrianoDee, @cmsbuild, @fwyzard, @kskovpen, @makortel, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again. |
7ed7486
to
0564de0
Compare
Pull request #45374 was updated. @AdrianoDee, @cmsbuild, @fwyzard, @kskovpen, @makortel, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again. |
enable gpu |
please test workflow 12634.402,12634.403,12634.404,12634.412,12661.402 |
please abort |
test parameters:
|
+heterogeneous Assuming the tests will pass. |
91ff907
to
ba4f358
Compare
+heterogeneous |
please test |
Pull request #45374 was updated. @AdrianoDee, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again. |
+1 Size: This PR adds an extra 44KB to repository The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
GPU Comparison SummarySummary:
|
+Upgrade |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
@VinInn pointed out that filling memory asynchronously may be incorrect if the memory is later being set synchronously, without using a queue.
This is often the case with pinned host memory buffers, where the allocation and memset may be asynchronous, but the content is accessed directly using host-only operations.
This change makes the allocator wait for the memset to complete before returning the memory buffer to the user code.
It also adds a customisation function to activate memory filling, and uses it in the non-profling Alpaka workflows.
PR validation:
None, yet.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backported of #45368 to 14.0.x.