Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CachingAllocator debug for non-async operations [14.0.x] #45374

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jul 4, 2024

PR description:

@VinInn pointed out that filling memory asynchronously may be incorrect if the memory is later being set synchronously, without using a queue.
This is often the case with pinned host memory buffers, where the allocation and memset may be asynchronous, but the content is accessed directly using host-only operations.

This change makes the allocator wait for the memset to complete before returning the memory buffer to the user code.

It also adds a customisation function to activate memory filling, and uses it in the non-profling Alpaka workflows.

PR validation:

None, yet.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backported of #45368 to 14.0.x.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 4, 2024

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 4, 2024

backport #45368

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 4, 2024

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 4, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2024

A new Pull Request was created by @fwyzard for CMSSW_14_0_X.

It involves the following packages:

  • HeterogeneousCore/AlpakaInterface (heterogeneous)

@fwyzard, @makortel can you please review it and eventually sign? Thanks.
@makortel, @missirol, @rovere this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2024

Pull request #45374 was updated. @AdrianoDee, @cmsbuild, @fwyzard, @kskovpen, @makortel, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2024

Pull request #45374 was updated. @AdrianoDee, @cmsbuild, @fwyzard, @kskovpen, @makortel, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 4, 2024

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 4, 2024

please test workflow 12634.402,12634.403,12634.404,12634.412,12661.402

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 4, 2024

please abort

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 4, 2024

test parameters:

  • enable = gpu
  • workflows_gpu = 12634.402,12634.403,12634.404,12634.412,12661.402

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 4, 2024

+heterogeneous

Assuming the tests will pass.

@fwyzard fwyzard force-pushed the Alpaka_CachingAllocator_debug_140x branch from 91ff907 to ba4f358 Compare July 4, 2024 18:13
@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 4, 2024

+heterogeneous

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 4, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2024

Pull request #45374 was updated. @AdrianoDee, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2024

+1

Size: This PR adds an extra 44KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe3a81/40244/summary.html
COMMIT: ba4f358
CMSSW: CMSSW_14_0_X_2024-07-04-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45374/40244/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe3a81/40244/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe3a81/40244/git-merge-result

Comparison Summary

Summary:

  • You potentially added 77 lines to the logs
  • Reco comparison results: 43 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3342828
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3342799
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

@srimanob
Copy link
Contributor

srimanob commented Jul 5, 2024

+Upgrade

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bb3ff08 into cms-sw:CMSSW_14_0_X Jul 11, 2024
13 checks passed
@fwyzard fwyzard deleted the Alpaka_CachingAllocator_debug_140x branch July 17, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants