Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] Add a protection for pathologic cases in MuonBeamspotConstraintValueMapProducer #45396

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

namapane
Copy link
Contributor

@namapane namapane commented Jul 8, 2024

This PR is a backport of #45243 to 14_0_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2024

A new Pull Request was created by @namapane for CMSSW_14_0_X.

It involves the following packages:

  • RecoMuon/GlobalTrackingTools (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@CeliaFernandez, @Fedespring, @HuguesBrun, @JanFSchulte, @abbiendi, @amagitte, @andrea21z, @bellan, @cericeci, @jhgoh, @missirol, @rociovilar, @trocino this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2024

cms-bot internal usage

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 8, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d879ce/40279/summary.html
COMMIT: b3542f0
CMSSW: CMSSW_14_0_X_2024-07-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45396/40279/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 8, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 42a4efd into cms-sw:CMSSW_14_0_X Jul 8, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants