Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track selection update in MTD Validation #45457

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

rdelliga
Copy link
Contributor

PR description:


This PR updates track selection in MtdValidation and moves mtdValidation_cfg.py to D110 scenario.
In particular, some efficiency plot for extrapolated tracks were fixed after an issue introduced with PR #44859, which moved detailed extrapolation check in MtdTracksValidation only on tracks associated to TP from signal event, without changing the corresponding harvester.
Furthermore, track selection in validation for tracks and vertices was updated and made consistent.
Finally, efficiency plots for tracks matched to Gen particles were removed, leaving only those with tracks associated to TP, and some efficiency plots to monitor low-pt tracks in ETL were added. 



The code was tested on the workflow
 TTbar_PU_14TeV and SinglePiFlatPt0p7To10, with geometry scenario 2026D110.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 15, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45457/40915

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rdelliga for master.

It involves the following packages:

  • Validation/MtdValidation (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@fabiocos, @martinamalberti, @missirol this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 64KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-88fc7e/40399/summary.html
COMMIT: b4f3bc7
CMSSW: CMSSW_14_1_X_2024-07-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45457/40399/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially removed 7 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3344938
  • DQMHistoTests: Total failures: 407
  • DQMHistoTests: Total nulls: 8
  • DQMHistoTests: Total successes: 3344503
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 12.924 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 23234.0,... ): 2.150 KiB MTD/Tracks
  • DQMHistoSizes: changed ( 23234.0,... ): 0.004 KiB MTD/Vertices
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@rdelliga
Copy link
Contributor Author

I checked the comparisons, changes as expected in mtd. Any further comment?

@tjavaid
Copy link

tjavaid commented Jul 17, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9c51130 into cms-sw:master Jul 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants