-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track selection update in MTD Validation #45457
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45457/40915
|
A new Pull Request was created by @rdelliga for master. It involves the following packages:
@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Size: This PR adds an extra 64KB to repository
Comparison SummarySummary:
|
I checked the comparisons, changes as expected in mtd. Any further comment? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR updates track selection in MtdValidation and moves mtdValidation_cfg.py to D110 scenario.
In particular, some efficiency plot for extrapolated tracks were fixed after an issue introduced with PR #44859, which moved detailed extrapolation check in MtdTracksValidation only on tracks associated to TP from signal event, without changing the corresponding harvester.
Furthermore, track selection in validation for tracks and vertices was updated and made consistent.
Finally, efficiency plots for tracks matched to Gen particles were removed, leaving only those with tracks associated to TP, and some efficiency plots to monitor low-pt tracks in ETL were added.
The code was tested on the workflow TTbar_PU_14TeV and SinglePiFlatPt0p7To10, with geometry scenario 2026D110.