Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hcalgpu online-DQM client (post HCAL-Alpaka port at HLT) [14_0_X] #45559

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Jul 25, 2024

backport of #45558

PR description:

From the description of #45558.

This PR updates the names of the collections consumed in the hcalgpu online-DQM client according to the content of the latest Run-3 HLT menus, which include the port of the HCAL local reconstruction to Alpaka (see CMSHLT-3281 and links therein). These HLT updates are set to be deployed online next week (Week-31 of 2024); when that happens, the hcalgpu client should be updated accordingly, with the change in this PR.

PR validation:

None.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#45558

Change to one online-DQM client to adapt to the latest HLT menus for 2024 data-taking.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 25, 2024

A new Pull Request was created by @missirol for CMSSW_14_0_X.

It involves the following packages:

  • DQM/Integration (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@batinkov, @francescobrivio, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 25, 2024

cms-bot internal usage

@missirol
Copy link
Contributor Author

@cms-sw/dqm-l2

This PR should be integrated in the online-DQM machines when we will change HLT menus (and Era) early next week. The branch used in this PR is based on CMSSW_14_0_12.

@tjavaid
Copy link

tjavaid commented Jul 26, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-521708/40628/summary.html
COMMIT: c42e645
CMSSW: CMSSW_14_0_X_2024-07-25-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45559/40628/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor

mmusich commented Jul 26, 2024

purely for the record (this PR is needed for actual data-taking), now the unit tests logs have this:

Begin processing the 1st record. Run 381594, Event 79014785, LumiSection 1000 on stream 0 at 26-Jul-2024 10:51:01.784 CEST
%MSG-w HcalGPUComparisonTask:  HcalGPUComparisonTask:hcalGPUComparisonTask  26-Jul-2024 10:51:01 CEST Run: 381594 Event: 79014785
Either CPU or GPU RecHit Collection is unavailable, will not fill this event.
%MSG

After this is merged I can update the input file as done in cms-data/DQM-Integration#8

@tjavaid
Copy link

tjavaid commented Jul 29, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9ac6890 into cms-sw:CMSSW_14_0_X Jul 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants