Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Mark ScopedContextAcquire destructor as noexcept(false) #45562

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

makortel
Copy link
Contributor

PR description:

This destructor can throw an exception that is wanted to be propagated upwards in the stack, even with the risk of double exceptions (and those leading to std::terminate()). See #45555 (comment) for more context.

PR validation:

None beyond #45560

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #45560

This destructor can throw an exception that is wanted to be propagated
upwards in the stack, even with the risk of double exceptions (and
those leading to std::terminate()).
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel for CMSSW_14_0_X.

It involves the following packages:

  • HeterogeneousCore/CUDACore (heterogeneous)

@cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks.
@missirol, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 25, 2024

cms-bot internal usage

@makortel
Copy link
Contributor Author

enable gpu

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c8f4ed/40623/summary.html
COMMIT: ac984dc
CMSSW: CMSSW_14_0_X_2024-07-25-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45562/40623/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 22 differences found in the comparisons
  • DQMHistoTests: Total files compared: 6
  • DQMHistoTests: Total histograms compared: 37022
  • DQMHistoTests: Total failures: 1023
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 35999
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 5 files compared)
  • Checked 20 log files, 25 edm output root files, 6 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor Author

Comparison differences are related to #39803 and #43790

@makortel
Copy link
Contributor Author

+heterogeneous

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3a38543 into cms-sw:CMSSW_14_0_X Jul 29, 2024
12 checks passed
@makortel makortel deleted the scopedContextAcquire_140x branch July 30, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants