Add LogWarning in OnlineBeamSpotESProducer::checkSingleBS

[francescobrivio]

PR description:

Title says it all.
Minor improvement to add a LogWarning (which was forgotten in the past implementation of the class) in case we fall back to PCL in the checkSingleBS method of OnlineBeamSpotESProducer.

PR validation:

Code compiles.

Backport:

Not a backport, no backport needed.

[cmsbuild]

cms-bot internal usage

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45565/41052

[cmsbuild]

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

• RecoVertex/BeamSpotProducer (reconstruction, alca)

@consuegs, @jfernan2, @mandrenguyen, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanFSchulte, @VinInn, @VourMa, @dgulhan, @fabiocos, @martinamalberti, @missirol, @mmusich, @mtosi, @rovere, @rsreds, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7bb704/40626/summary.html
COMMIT: d574656
CMSSW: CMSSW_14_1_X_2024-07-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45565/40626/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially removed 6 lines from the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3431776
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3431753
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 195 log files, 166 edm output root files, 45 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[francescobrivio]

hold

• I have one more minor thing to add, I'll do it tomorrow!

[cmsbuild]

Pull request has been put on hold by @francescobrivio
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45565/41077

[cmsbuild]

Pull request #45565 was updated. @cmsbuild, @consuegs, @jfernan2, @mandrenguyen, @perrotta, @saumyaphor4252 can you please check and sign again.

[francescobrivio]

@cmsbuild please test

• in any case I'm only changing the logwarning messages, so I don't expect any change in Physics

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7bb704/40667/summary.html
COMMIT: 4905ad3
CMSSW: CMSSW_14_1_X_2024-07-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45565/40667/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 5 lines to the logs
• Reco comparison results: 96 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3530483
• DQMHistoTests: Total failures: 2464
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3527999
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 200 log files, 170 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[francescobrivio]

Failures in DQM comparisons come almost exclusively from 12834.7 which is known from #39803 (other failures are from MessageLogger, i.e. not relevant).

[mandrenguyen]

+reconstruction

[perrotta]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1

[mmusich]

@francescobrivio do you mind backporting this?

[francescobrivio]

@francescobrivio do you mind backporting this?

👍 will do!